Repository navigation
[C#] Reorganize global and class-level contexts - #4625
Merged
Merged
Conversation
This commit rearranges includes in global and class-level contexts for both to share same structure, but primarily to ensure special declaration contexts always take precedence over common patterns such as attributes and modifiers. As a result `external-alias-declarations` no longer need to be injected somewhere in the middle of common modifiers, just to ensure its patterns match. Only behavior change: Label declarations are added to list of class-level fallback patterns to help with maintaining syntax highlighting in case of incomplete blocks or method definitions etc.
jrappen
approved these changes
Oct 5, 2026
michaelblyons
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit rearranges includes in global and class-level contexts for both to share same structure, but primarily to ensure special declaration contexts always take precedence over common patterns such as attributes and modifiers.
As a result
external-alias-declarationsno longer need to be injected somewhere in the middle of common modifiers, just to ensure its patterns match.Only behavior change:
Label declarations are added to list of class-level fallback patterns to help with maintaining syntax highlighting in case of incomplete blocks or method definitions etc.