Repository navigation
Fix credential guard gaps and clarify private-note storage - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The write guard accepted hyphenated AI-provider keys and secret assignments shorter than eight characters, allowing accidental credentials into Git-backed engagement records. Extend supported key characters and reject nonempty assignments regardless of length. Output masking covers the same assignment forms, including punctuation and escaped quotes.
Private-note confirmation now explains that hidden content remains plaintext in local files and Git history. Credential refusal explains that undo/redact does not erase history and exposed credentials need rotation. The deliberate
--forceoverride remains available with a warning.Includes version 5.1.24 and synthetic regression tests for write refusal, unchanged history, debrief/ingest, whole-value masking, and ordinary nonsecret text. No real credentials or customer records were used.
Validation
npm run check: 509 tests passed, zero failures or skips on the final revision.