Skip to content

Clarify standalone skills and conditional record guidance (5.2.0) - #169

Merged
suboss87 merged 2 commits into
Mainfrom
improve/skill-entry-and-review
Oct 5, 2026
Merged

suboss87 merged 2 commits into
Mainfrom
improve/skill-entry-and-review

Conversation

@suboss87

@suboss87 suboss87 commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

Outcome

Each of the 35 independently installable task skills now states its expected result at entry. The coordinator loads customer-record procedures only for record-backed work; standalone tasks retain the same supplied-context path and authority rules.

PR guidance now asks for observed evidence, affected scope and the limits of recovery. Canonical methods remain the single source; dependent packages are regenerated. Release metadata is 5.2.0.

Evidence

  • Coordinator entry reduced from 2,672 to about 1,757 words by moving record procedures behind an explicit conditional link. This is a loading-size change, not a measured model-quality claim.
  • Isolated installation tests cover all 35 task packages (22 passing test cases).
  • Routing contracts and live CLI smoke pass; reference-only model selection remains outside that CLI smoke.
  • Independent review found no remaining privacy, authority, continuity or dependency regressions.
  • Structural gate plus the complete 509-test suite pass with four parallel test files. The first default-parallel npm run check hit two five-second fixture-initialization timeouts (507 passed); all 14 ingest-boundary tests then passed in isolation. No assertion or timeout was changed. GitHub runs the standard npm run check gate.

Impact and recovery

Changes affect skill instructions, generated packages, validation and PR documentation. No CLI runtime behavior or customer data migration changes. A code revert restores prior instructions; already-published npm artifacts require a new release to replace the default version.

Checks

  • No customer data, factory research, private run artifacts or credentials included.

Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Comment thread skills/fde/SKILL.md Outdated
Comment on lines +24 to +26
## Record-backed work

For record-backed work only:

1. Before client reads, run `fde setup --show` and verify `fde privacy` support. If setup is unconfigured or the user requests preferences, follow `references/record-setup.md`. Setup does not authorize sharing customer data.
2. Use a fresh `fde resume` packet for this turn/task. Reuse a current session-hook packet only when its visible `ENGAGEMENT:` matches the binding and its freshness is certain. Refresh after binding, masking or record changes, or when the user asks where things stand. Do not reuse an earlier turn's packet or repeat the same entry solely because another method loaded.
3. Read policy, signer, goals, risks and current work. Retrieve omitted or disputed evidence, saved lessons and dated retrospectives with `fde recall <topic>`; never replace this with raw or recursive record reads. Resume defaults to 16 KiB (4 KiB in compact setup); `--max-bytes 4096` reduces it, and `--full` is for explicitly needed complete context.
4. For interrupted implementation, inspect the saved checkpoint and follow `references/verification.md#recoverable-checkpoint` before acting. A checkpoint is a dated claim, not a fresh test or permission to execute. For a returning or closed engagement, apply the reopening check in `references/land.md` before relying on historical access, owners or deployment evidence.
5. Give a brief playback and load the relevant method below. `hygiene:` means offer `fde doctor`; never auto-rewrite.

The CLI uses local files and Git, without network calls. Install it on the FDE's own machine, never customer infrastructure. The AI host's permissions and provider policy remain separate.
Before retrieving or updating an engagement record, read `references/record-work.md` for privacy-safe session entry, record commands, the memory contract and session digest. Load it once for the current task; standalone work does not require it. Confirm consequential record changes under task-context rules. A saved claim is not customer acceptance.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Installed adapters lose session entry guidance

For bound work, installed adapters still direct agents to Entry (every session) in the coordinator. That heading now lives only in record-work.md, so agents following the adapter miss setup and fresh context.

Learn more

The installer places adapter pointers in Codex, Gemini, Cursor, and Copilot workspaces. Their session entry pointers explicitly direct agents to the Entry (every session) heading in the coordinator skill. This change moves that heading into record-work.md, which the coordinator links conditionally. Following the adapter's literal heading now finds no entry instructions, leaving setup and resume refresh guidance undiscoverable along that path.

Example: An engineer opens a bound customer workspace in Cursor. Its installed rule says to follow Entry (every session) in the coordinator skill, but that heading is absent there. The agent can skip the current fde resume packet and work from an older status rather than refreshing the bound engagement.

Recommended fix: Update every installed adapter pointer to the new conditional location, or retain a matching heading in the coordinator that directs record-backed work to references/record-work.md. Cover installed adapters in a structural check so future instruction moves cannot leave their entry pointers stale.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@suboss87
suboss87 merged commit ed7f271 into Main Oct 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant