Repository navigation
Conversation
📦 PR builds ·
|
| Platform | Download |
|---|---|
| 🪟 Windows | hollow-windows-pr-f898a9c |
| 🐧 Linux | hollow-linux-pr-f898a9c |
Build details
| Detail | Value |
|---|---|
| 🧬 Commit | f898a9c |
| 🕒 Started | 28 Oct 2026, 22:05 UTC |
| ✅ Completed | 28 Oct 2026, 22:15 UTC |
| 🔗 Build run | #67 |
Artifacts expire after 7 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons, tabs, list rows and panel chrome previously derived paint and interaction styles through separate paths. Route them through private component recipes and a flat computed-style normalizer while retaining existing raw styles, theme overrides and legacy geometry. Live span serialization writes directly into its output to avoid intermediate style snapshots.
ui.styledcanonical and provideui.themed_styleas a compatibility alias.Validation:
scripts/test-lua.sh: 598 successes, 0 failures/errors using LuaJIT/Busted.fmt --checkandgit diff --checkpass.zig build test-luaandzig build testwere attempted but external Ghostty/LuaJIT/font dependency downloads fail with HttpConnectionClosing. Native compilation, screenshots and DPI/hit-region acceptance remain unverified.Lua render+overlay-serialization benchmark, baseline 68709b3 vs this change: 25 rows 0.953→0.896 ms; 100 rows 3.813→3.509 ms; 500 rows 25.380→24.408 ms. Allocated bytes/row increase about 3%; component-only allocations increase about 0.6%. These are host-specific Lua samples, not native frame-time claims. No generic style cache or synthetic pressed/focus behavior is introduced.
Row styles intentionally expose only supported text/background/radius/hover paint; unsupported row geometry fields error. Existing segment padding and native placement/hit-region calculations remain the compatibility boundary. Native visual/build acceptance is pending before merging.