Repository navigation
Bug: Tabs created after restore are not persisted #545
Description
Summary
Tabs created after restoring existing tabs are not persisted across restarts.
Steps to Reproduce
- Open Neovim, create Tab 1 and Tab 2, send a message in each
- Close Neovim
- Reopen — Tab 1 and Tab 2 restore correctly
- Create Tab 3, send a message
- Close Neovim
- Reopen — only Tab 1 and Tab 2 are restored, Tab 3 is missing
Root Cause
M.restore() returns early when existing tabs are detected:
local current = tabs.list()
if not untouched(current, background) then
return -- early return here
endBut group.restoring was set to true during the first restore():
group.restoring = true
restore_snapshot(...):await()
group.restoring = falseOn the second open, restore() returns early, leaving group.restoring = true.
M.save() checks:
if group.attempted and not group.failed and not group.restoring thenSince group.restoring == true, the group is skipped and tabs are not saved.
Verification
- After restore: 2 tabs
- After creating Tab 3: 3 tabs
M.save()returnsfalse- Snapshot file contains only 2 tabs (missing Tab 3)
Suggested Fix
Reset group.restoring = false when restore() returns early, or ensure the state is consistent before M.save() runs.
Environment
- OS: Windows 11
- Neovim: 0.12.5
- opencode.nvim: latest main (commit 494e474)
- opencode executable: opencode2 (v2 protocol)
Activity
wzj-zz commentedon Oct 21, 2026
I can confirm this bug is more severe than initially reported.
Test case:
<M-c>, send message "Hello Tab 2"Video demonstration:
issue545_compressed.mp4
This shows that ANY additional tab beyond the first is not persisted, not just "tabs created after restore".
Environment:
wzj-zz commentedon Oct 21, 2026
Update: The bug is more severe than initially reported.
Original scenario (cannot test due to this bug):
Current scenario (confirmed):
This suggests PR #542 may have introduced a regression where ANY additional tab beyond the first is not persisted.
Steps:
<M-c>, send messageVideo: issue545_compressed.mp4
Environment: latest main (97566da)
cc @sudo-tee @jensenojs
fix(session): persist empty tabs as containers
fix(session): fix snapshot write failure on Windows
fix(session): fix snapshot write failure on Windows
fix(session): fix snapshot write failure on Windows
fix(session): fix snapshot write failure on Windows (sudo-tee#548)