Repository navigation
feat(typegen)!: generate only from the document the Supabase CLI pipes in - #1963
Merged
Merged
Conversation
…s in Remove the built-in database introspection and the --local, --linked, --project-ref, --db-url and --dump-metadata options. supabase_typegen now only reads the GeneratorMetadata document that `supabase gen types --lang dart` pipes in on stdin, which pg-meta has already introspected, sorted and resolved rpcFunctions for.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main breaking change: type generation now uses only the document piped from the Supabase CLI. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
supabase_typegenno longer connects to a database itself. Its only input is now theGeneratorMetadatadocument thatsupabase gen types --lang dartpipes in on stdin. Before this change it could also run on its own, through a Dart port of the@supabase/postgrest-typegenintrospection. That port repeated work the CLI flow already does: pg-meta introspects the database, sorts the document withsortGeneratorMetadataand attachesrpcFunctions.Changes
--local,--linked,--project-ref,--db-urland--dump-metadataoptions.--schema,--outputand--importstay.package:supabase_typegen/introspection.dartlibrary: the vendored introspection SQL, thesupabase db queryrunner, theconfig.tomlschema defaults, the sort pass and its ICU collation.resolveRpcFunctions. The parser now readsrpcFunctionsfrom the document, and a document without that collection describes no RPC functions.test.yml, and the now unusedtoml,collectionandpostgresdependencies.MIGRATION.mdto usesupabase gen types --lang dart.The
test/fixtures/generator_metadata.jsonfixture is still generated by the upstream TypeScript introspection (tool/regenerate_fixture.ts), so the generator and parser tests run against exactly the document the CLI produces.Breaking
Running
dart run supabase_typegen --local(or any other connection option) now fails with an unknown option error. Usesupabase gen types --lang dart --local > lib/supabase_schema.g.dartinstead.Summary by CodeRabbit