Skip to content

docs(auth): note that listProviders ignores the prefix when both filters are given - #1967

Merged
spydon merged 1 commit into
mainfrom
lukasklingsbo/sso-list-providers-filter-doc
Oct 16, 2026
Merged

spydon merged 1 commit into
mainfrom
lukasklingsbo/sso-list-providers-filter-doc

Conversation

@spydon

@spydon spydon commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

When listProviders gets both resourceId and resourceIdPrefix, the Auth server filters by resource_id alone and quietly ignores the prefix. The dartdoc now says so.

Follow-up to #1966 (SDK-2257).

Summary by CodeRabbit

  • Documentation
    • Clarified that when both resource ID filters are provided, results are filtered by the exact resource ID.

@github-actions github-actions Bot added the auth This issue or pull request is related to authentication label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: supabase/supabase-flutter/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 729a6527-b876-4d6b-bd29-558baf679ca6
📥 Commits

Reviewing files that changed from the base of the PR and between c3a6a81 and 1d401b4.

📒 Files selected for processing: 1
  • packages/supabase_auth/lib/src/auth_admin_sso_api.dart

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The listProviders documentation now states that when both resourceId and resourceIdPrefix are supplied, the server filters by resourceId alone.

Changes: SSO provider filters

Layer / File(s) Summary
Document filter precedence
packages/supabase_auth/lib/src/auth_admin_sso_api.dart
The documentation states that the server uses resourceId alone when both filters are supplied.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: cmelchior

Merge Risk: ⚪ Minimal · up to 1d401

The documentation clarifies that exact resource ID takes precedence when both filters are supplied, matching the inspected Auth implementation. No concrete user-facing regression is established, so the change is mergeable.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the documentation change for listProviders when both filters are provided.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@spydon
spydon enabled auto-merge (squash) October 16, 2026 12:29
@spydon
spydon merged commit 35f6cff into main Oct 16, 2026
44 checks passed
@spydon
spydon deleted the lukasklingsbo/sso-list-providers-filter-doc branch October 16, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth This issue or pull request is related to authentication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant