test(auth): cover phone on a non-phone factor in updateFactor

[spydon]

Follow-up to #1965 (SDK-2256), whose last commit landed after it was merged.

What

• Corrects the AuthAdminMFAApi.updateFactor dartdoc: the server treats an empty string as not given, so a friendly name cannot be cleared, and it ignores phone on factors that are not phone factors.
• Adds an integration test that sends a phone number to the seeded TOTP factor and checks that the call succeeds and leaves the factor unchanged, as the capability spec describes.

Verification

The auth_admin_mfa_api_test.dart suite passes against the local stack. Format and DCM are clean.

Summary by CodeRabbit

• Documentation
  • Clarified that an empty friendly name is treated as not provided and that phone numbers are ignored for non-phone factors.
• Tests
  • Added coverage confirming that supplying a phone number when updating a TOTP factor does not change its ID, type, or friendly name.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: supabase/supabase-flutter/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 9ec49b9b-0d2d-4022-95f2-351f03f749d5

📥 Commits

Reviewing files that changed from the base of the PR and between 35f6cff and 2f74334.

📒 Files selected for processing: 2

• packages/supabase_auth/lib/src/auth_admin_mfa_api.dart
• packages/supabase_auth/test/src/auth_admin_mfa_api_test.dart

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The updateFactor documentation clarifies empty-string handling and notes that phone is ignored for non-phone factors. A test checks that supplying a phone number leaves a TOTP factor's ID, type, and friendly name unchanged.

Changes: MFA factor update

Layer / File(s)	Summary
Document and test update behavior packages/supabase_auth/lib/src/auth_admin_mfa_api.dart, packages/supabase_auth/test/src/auth_admin_mfa_api_test.dart	The documentation describes empty-string handling and ignored phone values for non-phone factors. The test checks that a TOTP factor's ID, type, and friendly name remain unchanged when a phone number is supplied.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: cmelchior

Merge Risk: ⚪ Minimal · up to 2f743

The documentation matches the server’s empty-name behavior, and the test covers supplying a phone number to a TOTP factor. No actionable merge risk remains.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: adding coverage for supplying a phone number to a non-phone factor in updateFactor.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}