Repository navigation
fix(auth): check persistSession up front and give examples a storage - #1972
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1971 for SDK-2259.
Changes
SupabaseClientnow also catchespersistSession: truewithout anasyncStorageup front, with its own message pointing atauthOptionsorpersistSession: false. Before, that case fell through to theAuthClientmessage, which doesn't mentionSupabaseClient, after the default HTTP client had already been created.YAJsonIsolatedoesn't spawn a long-lived isolate, so there was nothing to clean up.supabaseweb example and the second client in the realtime room integration test now pass aMemoryAuthAsyncStorage. Since fix(auth)!: throw when a client has no asyncStorage for the pkce flow #1971, both throw when they are created.AuthExceptionfromexchangeCodeForSessionon an implicit-flow client without a storage.SupabaseClientdartdoc and the MIGRATION.md section to match.