Conversation
Donmai native drift checkCommit: Policy passed. This is regex-based diff analysis, not a learned architectural baseline or a semantic review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhoneNumberKit 5.0.4 predates the upstream 5.0.10 input-normalization denial-of-service fix. Raise the minimum to 5.0.11 and update the resolved revision to
faf1703e6fc71c699e911ff0e306c58ad7c756c0. The other three dependencies and the macOS 14 deployment target remain unchanged.The color integration test now runs
chatsagainst an absent SQLite file in its own temporary directory with an explicitKITH_DB_PATH. It still checks the color override, and also checks exit 6,DB_UNAVAILABLE, and that no database file was created. This makes the complete suite safe to run locally without contacting or bootstrapping an installed agent.Upstream: 5.0.10 security fix, 5.0.11 release.
Validation:
swift buildpassed;swift test --parallelpassed all 79 tests with no skips. In a disposable copy, ignoring--colormade the forced-color assertion fail; the unchanged code passed the focused test again. Every invocation in that control retained the explicit missingKITH_DB_PATH.