[Ruj89]

Flashing the OmniDrive 1.0.4 experimental firmware from https://github.com/Ruj89/OmniDrive ASUS BW-12B1LT should be fully supported

Summary by CodeRabbit

• New Features
  • Added experimental support for the ASUS BW-12B1LT optical drive, enabling the app to apply its configured disc-reading settings when handling this model.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: a0ba9e43-0180-488c-9af3-d903f5b6090c

📥 Commits

Reviewing files that changed from the base of the PR and between 3a8f8ff and 4ad84f6.

📒 Files selected for processing: 1

• drive.ixx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The drive database now includes an ASUS BW-12B1LT configuration with BE reads, DATA_C2_SUB sector ordering, a +6 read offset, zero C2 shift, and a −135 pregap start.

Changes: Drive database entry

Layer / File(s)	Summary
Add ASUS drive parameters drive.ixx	Adds an ASUS BW-12B1LT configuration with read offset +6, zero C2 shift, pregap start −135, BE reading, and DATA_C2_SUB sector ordering.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: superg

Merge Risk: ⚪ Minimal · up to 4ad84

The drive database addition is mergeable with no identified user-impacting regression.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the ASUS BW-12B1LT drive support added by the pull request. It matches the main change.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[superg]

I would be happy to add that once it gets into RibShark/OmniDrive and I get a confirmation, please keep me updated.

[Deterous]

Does the drive support reading leadin?

[Ruj89]

Using a mixed-mode CD on Linux (Time Crisis) redumper drive test successfully read 135 sectors before LBA 0, but those are in the pre-gap, so that doesn’t confirm access to the actual lead-in. I then used sg_raw to test OmniDrive’s custom READ DISC RAW command. Reading LBA 0 worked, including subchannels. A request targeting LBA -225 failed with “L-EC uncorrectable error” and returned no data.
So lead-in reading is still unconfirmed on this setup. The firmware’s handling of negative addresses needs checking before calling this a drive limitation. I'll let you know.

[Deterous]

135 sectors of pregap (in the leadin, aka Track 1 pregap) should be input in your PR. The drive is standard MT1939, so it should have it and the lack of full leadin is expected.