-
Notifications
You must be signed in to change notification settings - Fork 312
Fix/overflow policy validation #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RoopakBRK
wants to merge
4
commits into
superlinked:main
Choose a base branch
from
RoopakBRK:fix/overflow-policy-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−1
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
27d4f46
fix(api): validate overflow policy type
RoopakBRK 4917b08
fix(api): validate overflow policy type
RoopakBRK 43d39d9
test(api): cover invalid overflow policy type
RoopakBRK e902cb6
Merge branch 'main' into fix/overflow-policy-validation
RoopakBRK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| from unittest.mock import MagicMock | ||
|
|
||
| import pytest | ||
| from fastapi import HTTPException | ||
| from sie_server.api.options import resolve_runtime_options_with_profile | ||
| from sie_server.config.model import EmbeddingDim, EncodeTask, ModelConfig, ProfileConfig, Tasks | ||
|
|
||
|
|
||
| def _make_config() -> ModelConfig: | ||
| return ModelConfig( | ||
| sie_id="test", | ||
| hf_id="org/test", | ||
| tasks=Tasks(encode=EncodeTask(dense=EmbeddingDim(dim=8))), | ||
| profiles={ | ||
| "default": ProfileConfig( | ||
| adapter_path="sie_server.adapters.base:ModelAdapter", | ||
| max_batch_tokens=8, | ||
| ) | ||
| }, | ||
| ) | ||
|
|
||
|
|
||
| def test_invalid_overflow_policy_type_returns_400() -> None: | ||
| span = MagicMock() | ||
|
|
||
| with pytest.raises(HTTPException) as exc_info: | ||
| resolve_runtime_options_with_profile( | ||
| _make_config(), | ||
| {"overflow_policy": ["truncate_text"]}, | ||
| span, | ||
| ) | ||
|
|
||
| assert exc_info.value.status_code == 400 | ||
| assert exc_info.value.detail["code"] == "INVALID_INPUT" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test? Nothing in the suite currently touches this validation branch at all. No test references invalid_overflow_policy. so right now nothing proves the fix works and nothing stops it coming back. A single case asserting {"overflow_policy": ["truncate_text"]} returns 400 would cover it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay will be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test covering the invalid overflow_policy type case. It verifies that passing a list returns the expected 400 INVALID_INPUT response.