Repository navigation
Calculating XS ratio statistics - #327
Merged
Merged
Conversation
eitan-weinstein
force-pushed
the
xs_relative_stats
branch
from
October 13, 2026 13:59
5a4b861 to
86aac1a
Compare
gonuke
requested changes
Oct 13, 2026
gonuke
left a comment
gonuke
left a comment
Member
There was a problem hiding this comment.
Just one quick clarification...
Comment on lines
+170
to
+173
| reference_group (str): Group name of the reference group against which | ||
| to divide other group structures' cross-sections. Will be an empty | ||
| string if none of the provided DSV paths in `dsv_list` contain a | ||
| '(reference)' tag in the string (i.e. example.dsv (reference)). |
Member
There was a problem hiding this comment.
Does this actually get returned?
Contributor
Author
There was a problem hiding this comment.
Nope, good catch. That was a holdover from before the rebase
eitan-weinstein
force-pushed
the
xs_relative_stats
branch
from
October 14, 2026 13:13
86aac1a to
e645224
Compare
gonuke
approved these changes
Oct 14, 2026
gonuke
left a comment
gonuke
left a comment
Member
There was a problem hiding this comment.
Looks good - thanks @eitan-weinstein
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #307.
This PR updates the function
xs_plotting.plot_relative_group_xs()to calculate the mean and standard deviation of every plotted ratio series usingnp.nanmean()ornp.nanstd()respectively (to account for regions in which the control series may be zero). These values are included both in the legend of the ratio plots, akin to the approach inalara_output_processing/alara_output_plotting.py, while also saving all statistics to a DataFrame corresponding to each ratio plot produced that is saved as a CSV upon the completion of the script.