Repository navigation
Loading/procesing all DSV to DataFrame once - #337
Merged
Merged
Conversation
gonuke
approved these changes
Oct 13, 2026
gonuke
left a comment
gonuke
left a comment
Member
There was a problem hiding this comment.
Looks good to me... Thanks @eitan-weinstein
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After finalizing the newest Pandas DSV reading implemented in the last commit of #307, I realized that
xs_plotting.find_all_MTs()already usedpd.read_csv()in more or less the same way. To eliminate the need to parse the large DSV files multiple times, this PR simply extracts the new DSV processing methods from #307 into its own functionxs_plotting.load_dsvs_to_dfs()to create a dictionary keyed by each DSV filepath being plotted with its associated loaded DataFrame.