Repository navigation
Add link preview image, meta description and Open Graph tags - #109
Open
JosephDavisC wants to merge 1 commit into
Open
JosephDavisC wants to merge 1 commit into
JosephDavisC wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Joseph Chamdani
What changes were made?
public/og-image.png(1200×630, 56 KB), styled after the app: white background, the existingtransp-swecc-logo.pngwith the samebrightness(0.6) contrast(1.5)filter the nav bar uses, Interview in bold italic monospace like the header, the tagline in Inter,interview.swecc.org, and a small availability grid that echoes the signup step.index.html, added to<head>:description: "Sign up for weekly mock interviews with other SWECC members."og:type,og:site_name,og:title(same as the existing<title>, "Mock Interview Signup"),og:description,og:url,og:imagewith width, height and alt text.twitter:card=summary_large_image, so X shows the full-width image.<link rel="canonical" href="https://interview.swecc.org/">. It's a single-page app, so every route serves this sameindex.html, and the logged-in pages point search engines back to the signup page.The existing
<title>, favicon and app code are unchanged.Why are these changes important/necessary?
The page only has a
<title>, so an interview.swecc.org link shared in Discord, LinkedIn, iMessage or Slack shows a bare title with no description or image, and Google shows no description (see the Before screenshot). With Interview coming back this week, the signup link will get shared a lot, so it should have a proper preview card.Same change as swecc-uw/swecc-labs#64 (live on labs.swecc.org) and swecc-uw/swecc-website#169.
Verification:
npm run lint: 0 errors (the 8 warnings already exist onmain).npm run spellcheck: 0 issues, including the new tags inindex.html.npm run build: passes, anddist/og-image.pngis in the output (Vite copiespublic/as-is).vite preview:/og-image.pngreturns 200image/png(56 KB) and the page has all 12 new tags.https://URL, which crawlers need.(If applicable) Screenshots of your changes. Providing an "old vs. new" comparison would be great!
New preview image (
public/og-image.png)Before: metatags.io reading interview.swecc.org today. After: the same tool with this PR's title, description and image (the image can't be read from interview.swecc.org until this is deployed).
Need help on this PR? Tag
@codesmith-botwith what you need.