Add PC Switch Control profiles and output engine - #467
Merged
Conversation
- Add validated atomic profile persistence with immutable built-in Grid 3 and keyboard profiles - Add mapped desktop and Grid output sessions with state reconciliation and deterministic cleanup - Add an accessible eight-slot profile manager and focused engine tests 🤖 Auto-generated
4 tasks
- Canonicalize stored key and shortcut tokens for Windows input - Retain failed provider cleanup state for deterministic retries - Make binding values discoverable and focus invalid switch rows - Add regression coverage for cleanup and normalization failures 🤖 Auto-generated
Contributor
Author
|
Independent review follow-up is complete with no remaining findings. Key tokens are canonicalized, failed provider cleanup remains retryable, shortcut cleanup is best-effort and recoverable, and the editor now exposes type-specific choices plus row-focused accessible validation. Verification: Release build passes with 0 warnings; 490 unit tests and 1 integration test pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #465
Test plan