Skip to content

Fix switch profile editing UX #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enaboapps merged 1 commit into from
Jul 28, 2026
Merged

Fix switch profile editing UX #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/SwitchifyPc.App/SwitchControlProfileWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
xmlns:shell="clr-namespace:System.Windows.Shell;assembly=PresentationFramework"
xmlns:chrome="clr-namespace:SwitchifyPc.App.Chrome"
Title="PC Switch Control profiles"
Width="980"
Height="720"
MinWidth="760"
MinHeight="560"
Width="900"
Height="690"
ResizeMode="NoResize"
WindowStartupLocation="CenterOwner"
Icon="Assets/icon.ico"
Expand Down Expand Up @@ -501,11 +503,6 @@
MinWidth="84"
Style="{StaticResource PrimaryButton}"
Click="Save_Click" />
<Button Margin="8,0,0,0"
Content="Close"
MinWidth="84"
IsCancel="True"
Click="Close_Click" />
</StackPanel>
</Grid>
</Grid>
Expand Down
174 changes: 161 additions & 13 deletions src/SwitchifyPc.App/SwitchControlProfileWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,53 +14,128 @@ public partial class SwitchControlProfileWindow : Window
{
private readonly ISwitchControlProfileStore store;
private readonly Func<string?> activeProfileId;
private readonly Func<MessageBoxResult> confirmUnsavedChanges;
private IReadOnlyList<SwitchControlProfile> profiles = [];
private SwitchControlProfile? selected;
private ProfileEditSnapshot? cleanSnapshot;
private bool isEditable;
private bool isTransient;
private bool isDirty;
private bool suppressDirtyTracking;
private bool suppressSelectionChange;
private readonly BindingRowViewModel[] rows =
Enumerable.Range(1, 8).Select(id => new BindingRowViewModel(id)).ToArray();

public SwitchControlProfileWindow(
ISwitchControlProfileStore store,
Func<string?> activeProfileId)
: this(store, activeProfileId, ShowUnsavedChangesPrompt)
{
}

internal SwitchControlProfileWindow(
ISwitchControlProfileStore store,
Func<string?> activeProfileId,
Func<MessageBoxResult> confirmUnsavedChanges)
{
this.store = store;
this.activeProfileId = activeProfileId;
this.confirmUnsavedChanges = confirmUnsavedChanges;
InitializeComponent();
BindingRows.ItemsSource = rows;
ProfileName.TextChanged += (_, _) => RefreshDirtyState();
foreach (BindingRowViewModel row in rows)
{
row.PropertyChanged += (_, _) => RefreshDirtyState();
}
Reload();
}

private void Reload(string? selectId = null)
{
profiles = store.Load();
ProfilesList.ItemsSource = profiles;
ProfilesList.SelectedItem = profiles.FirstOrDefault(profile => profile.Id == selectId) ?? profiles.FirstOrDefault();
SwitchControlProfile? profile =
profiles.FirstOrDefault(candidate => candidate.Id == selectId) ?? profiles.FirstOrDefault();
SelectAndLoad(profile);
}

private void ProfilesList_SelectionChanged(object sender, SelectionChangedEventArgs e)
{
if (ProfilesList.SelectedItem is not SwitchControlProfile profile) return;
if (suppressSelectionChange ||
ProfilesList.SelectedItem is not SwitchControlProfile profile ||
profile.Id == selected?.Id)
{
return;
}

if (isDirty)
{
string targetId = profile.Id;
switch (confirmUnsavedChanges())
{
case MessageBoxResult.Yes:
if (!TrySave())
{
RestoreSelectedProfile();
return;
}
Reload(targetId);
return;
case MessageBoxResult.No:
Reload(targetId);
return;
default:
RestoreSelectedProfile();
return;
}
}

LoadProfile(profile);
}

protected override void OnClosing(CancelEventArgs e)
{
if (isDirty)
{
MessageBoxResult decision = confirmUnsavedChanges();
if (decision == MessageBoxResult.Cancel ||
decision == MessageBoxResult.Yes && !TrySave())
{
e.Cancel = true;
}
}

base.OnClosing(e);
}

private void LoadProfile(SwitchControlProfile profile, bool transient = false)
{
suppressDirtyTracking = true;
selected = profile;
bool editable = !profile.IsBuiltIn && profile.Id != activeProfileId();
isEditable = !profile.IsBuiltIn && profile.Id != activeProfileId();
isTransient = transient;
ProfileName.Text = profile.Name;
ProfileName.IsEnabled = editable;
ProfileName.IsEnabled = isEditable;
ReadOnlyMessage.Text = profile.IsBuiltIn
? "Built-in profiles are read-only. Duplicate this profile to customize it."
: editable
: isEditable
? ""
: "This profile is active and cannot be changed until PC Switch Control stops.";
foreach ((BindingRowViewModel row, SwitchControlBinding binding) in rows.Zip(profile.Bindings))
{
row.Load(binding, editable);
row.Load(binding, isEditable);
}
SaveButton.IsEnabled = editable;
CancelButton.IsEnabled = editable;
DeleteButton.IsEnabled = editable;
cleanSnapshot = CaptureSnapshot();
suppressDirtyTracking = false;
DeleteButton.IsEnabled = isEditable;
ValidationMessage.Text = "";
RefreshDirtyState();
}

private void New_Click(object sender, RoutedEventArgs e)
{
if (!ResolvePendingChanges()) return;
EditUnsaved(new SwitchControlProfile(
Guid.NewGuid().ToString(),
1,
Expand All @@ -71,6 +146,7 @@ private void New_Click(object sender, RoutedEventArgs e)

private void Duplicate_Click(object sender, RoutedEventArgs e)
{
if (!ResolvePendingChanges()) return;
if (selected is null) return;
EditUnsaved(selected with
{
Expand All @@ -89,19 +165,24 @@ private void EditUnsaved(SwitchControlProfile profile)
{
profiles = [.. profiles, profile];
ProfilesList.ItemsSource = profiles;
suppressSelectionChange = true;
ProfilesList.SelectedItem = profile;
suppressSelectionChange = false;
LoadProfile(profile, transient: true);
ProfilesList.ScrollIntoView(profile);
}

private void Save_Click(object sender, RoutedEventArgs e)
private void Save_Click(object sender, RoutedEventArgs e) => TrySave();

private bool TrySave()
{
if (selected is null || selected.IsBuiltIn || selected.Id == activeProfileId()) return;
if (selected is null || !isEditable) return false;
BindingRowViewModel? invalidRow = rows.FirstOrDefault(row => !row.IsLocallyValid());
if (invalidRow is not null)
{
ValidationMessage.Text = $"Switch {invalidRow.SwitchId}: {invalidRow.ValueHelp}";
FocusBindingValue(invalidRow);
return;
return false;
}
try
{
Expand All @@ -119,11 +200,13 @@ private void Save_Click(object sender, RoutedEventArgs e)
.ToArray();
store.Save(custom);
Reload(saved.Id);
return true;
}
catch (Exception error) when (error is InvalidDataException or IOException or UnauthorizedAccessException)
{
ValidationMessage.Text = error.Message;
ProfileName.Focus();
return false;
}
}

Expand All @@ -142,7 +225,64 @@ private void Delete_Click(object sender, RoutedEventArgs e)
Reload();
}

private void Close_Click(object sender, RoutedEventArgs e) => Close();
private bool ResolvePendingChanges()
{
if (!isDirty) return true;
return confirmUnsavedChanges() switch
{
MessageBoxResult.Yes => TrySave(),
MessageBoxResult.No => DiscardPendingChanges(),
_ => false
};
}

private bool DiscardPendingChanges()
{
Reload(selected?.Id);
return true;
}

private void SelectAndLoad(SwitchControlProfile? profile)
{
suppressSelectionChange = true;
ProfilesList.SelectedItem = profile;
suppressSelectionChange = false;
if (profile is not null)
{
LoadProfile(profile);
}
}

private void RestoreSelectedProfile()
{
suppressSelectionChange = true;
ProfilesList.SelectedItem = selected;
suppressSelectionChange = false;
}

private void RefreshDirtyState()
{
if (suppressDirtyTracking || cleanSnapshot is null) return;
ProfileEditSnapshot current = CaptureSnapshot();
isDirty = isEditable &&
(isTransient ||
!string.Equals(current.Name, cleanSnapshot.Name, StringComparison.Ordinal) ||
!current.Bindings.SequenceEqual(cleanSnapshot.Bindings));
SaveButton.IsEnabled = isDirty;
CancelButton.IsEnabled = isDirty;
}

private ProfileEditSnapshot CaptureSnapshot() =>
new(
ProfileName.Text,
rows.Select(row => new BindingEditSnapshot(row.SelectedType, row.Value)).ToArray());

private static MessageBoxResult ShowUnsavedChangesPrompt() =>
WpfMessageBox.Show(
"Save changes to this profile before continuing?\n\nChoose No to discard them.",
"Unsaved PC Switch Control changes",
MessageBoxButton.YesNoCancel,
MessageBoxImage.Warning);

private string UniqueName(string proposed)
{
Expand Down Expand Up @@ -179,6 +319,14 @@ private static IEnumerable<T> FindDescendants<T>(DependencyObject parent)
}
}

private sealed record ProfileEditSnapshot(
string Name,
IReadOnlyList<BindingEditSnapshot> Bindings);

private sealed record BindingEditSnapshot(
SwitchBindingType Type,
string Value);

private sealed class BindingRowViewModel : INotifyPropertyChanged
{
private SwitchBindingType selectedType;
Expand Down
1 change: 1 addition & 0 deletions src/SwitchifyPc.App/SwitchifyPc.App.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

<ItemGroup>
<AssemblyMetadata Include="TimberlogsApiKey" Value="$(TIMBERLOGS_API_KEY)" />
<InternalsVisibleTo Include="SwitchifyPc.Tests" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading