Skip to content

Show friendly switch actions and validate changes immediately #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enaboapps merged 1 commit into from
Jul 28, 2026
+370 −28
Merged

Show friendly switch actions and validate changes immediately #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/SwitchifyPc.App/SwitchControlProfileWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,13 +451,17 @@
<ComboBox Grid.Column="1"
Margin="0,0,10,0"
ItemsSource="{Binding Types}"
SelectedItem="{Binding SelectedType, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
DisplayMemberPath="Label"
SelectedValuePath="Value"
SelectedValue="{Binding SelectedType, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
IsEnabled="{Binding IsEditable}"
AutomationProperties.Name="{Binding TypeAutomationName}" />
<ComboBox x:Name="BindingValueInput"
Grid.Column="2"
ItemsSource="{Binding ValueOptions}"
Text="{Binding Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
DisplayMemberPath="Label"
TextSearch.TextPath="Label"
Text="{Binding ValueDisplay, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
IsEditable="True"
IsTextSearchEnabled="True"
IsEnabled="{Binding IsEditable}"
Expand All @@ -467,8 +471,19 @@
Grid.Column="1"
Grid.ColumnSpan="2"
Margin="0,5,0,0"
Text="{Binding ValueHelp}"
Style="{StaticResource MutedText}" />
Text="{Binding FeedbackText}"
AutomationProperties.LiveSetting="Polite">
<TextBlock.Style>
<Style TargetType="TextBlock" BasedOn="{StaticResource MutedText}">
<Style.Triggers>
<DataTrigger Binding="{Binding HasValidationError}" Value="True">
<Setter Property="Foreground" Value="{DynamicResource StatusError}" />
<Setter Property="FontWeight" Value="SemiBold" />
</DataTrigger>
</Style.Triggers>
</Style>
</TextBlock.Style>
</TextBlock>
</Grid>
</Border>
</DataTemplate>
Expand Down
228 changes: 207 additions & 21 deletions src/SwitchifyPc.App/SwitchControlProfileWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,8 +333,24 @@ private void RefreshDirtyState()
(isTransient ||
!string.Equals(current.Name, cleanSnapshot.Name, StringComparison.Ordinal) ||
!current.Bindings.SequenceEqual(cleanSnapshot.Bindings));
SaveButton.IsEnabled = isDirty;
bool isValid = IsProfileLocallyValid();
SaveButton.IsEnabled = isDirty && isValid;
CancelButton.IsEnabled = isDirty;
ValidationMessage.Text = IsProfileNameLocallyValid()
? ""
: "Profile names must be unique and contain 1 to 50 characters.";
}

private bool IsProfileLocallyValid() =>
IsProfileNameLocallyValid() && rows.All(row => row.IsLocallyValid());

private bool IsProfileNameLocallyValid()
{
string name = ProfileName.Text.Trim();
return name.Length is >= 1 and <= 50 &&
profiles.All(profile =>
profile.Id == selected?.Id ||
!string.Equals(profile.Name, name, StringComparison.OrdinalIgnoreCase));
}

private ProfileEditSnapshot CaptureSnapshot() =>
Expand Down Expand Up @@ -392,11 +408,20 @@ private sealed record BindingEditSnapshot(
SwitchBindingType Type,
string Value);

private sealed record BindingTypeOption(
SwitchBindingType Value,
string Label);

private sealed record BindingValueOption(
string Value,
string Label);

private sealed class BindingRowViewModel : INotifyPropertyChanged
{
private SwitchBindingType selectedType;
private string value = "";
private bool isEditable;
private bool isLoading;

public BindingRowViewModel(int switchId)
{
Expand All @@ -408,55 +433,86 @@ public BindingRowViewModel(int switchId)
public string SwitchLabel => $"Switch {SwitchId}";
public string TypeAutomationName => $"Switch {SwitchId} action type";
public string ValueAutomationName => $"Switch {SwitchId} action value";
public IReadOnlyList<SwitchBindingType> Types { get; } = Enum.GetValues<SwitchBindingType>();
public IReadOnlyList<BindingTypeOption> Types { get; } = BindingTypes;

public SwitchBindingType SelectedType
{
get => selectedType;
set
{
if (selectedType == value)
{
return;
}

selectedType = value;
if (!isLoading)
{
SetRawValue("");
}
Changed();
Changed(nameof(ValueOptions));
Changed(nameof(ValueHelp));
Changed(nameof(FeedbackText));
Changed(nameof(HasValidationError));
}
}

public string Value
{
get => value;
set { this.value = value; Changed(); }
set => SetRawValue(value);
}

public string ValueDisplay
{
get => DisplayValue(SelectedType, value);
set => SetRawValue(RawValue(SelectedType, value));
}

public bool IsEditable
{
get => isEditable;
private set { isEditable = value; Changed(); }
private set
{
isEditable = value;
Changed();
Changed(nameof(FeedbackText));
Changed(nameof(HasValidationError));
}
}

public IReadOnlyList<string> ValueOptions => SelectedType switch
public IReadOnlyList<BindingValueOption> ValueOptions => SelectedType switch
{
SwitchBindingType.Key => KeyValues,
SwitchBindingType.MouseButton => ["left", "right", "middle"],
SwitchBindingType.Shortcut => ["Ctrl + C", "Ctrl + V", "Alt + Tab", "Ctrl + Shift + Escape"],
SwitchBindingType.MouseClick => ["left", "left:2", "right", "right:2", "middle", "middle:2"],
SwitchBindingType.Scroll => ["up", "down", "left", "right"],
SwitchBindingType.Media => ["playPause", "nextTrack", "previousTrack", "volumeUp", "volumeDown", "mute"],
SwitchBindingType.Key => KeyOptions,
SwitchBindingType.MouseButton => MouseButtonOptions,
SwitchBindingType.Shortcut => ShortcutOptions,
SwitchBindingType.MouseClick => MouseClickOptions,
SwitchBindingType.Scroll => ScrollOptions,
SwitchBindingType.Media => MediaOptions,
_ => []
};

public string ValueHelp => SelectedType switch
{
SwitchBindingType.None => "No value is required.",
SwitchBindingType.Key => "Choose one keyboard key.",
SwitchBindingType.MouseButton => "Choose left, right, or middle.",
SwitchBindingType.MouseButton => "Choose a mouse button to hold while the switch is pressed.",
SwitchBindingType.Shortcut => "Enter one to four unique keys separated by +, including a non-modifier.",
SwitchBindingType.MouseClick => "Choose a button, with :2 for a double click.",
SwitchBindingType.Scroll => "Choose up, down, left, or right.",
SwitchBindingType.MouseClick => "Choose a single or double mouse click.",
SwitchBindingType.Scroll => "Choose a scroll direction.",
SwitchBindingType.Media => "Choose play/pause, track, volume, or mute.",
_ => "Choose a valid value."
};

public bool HasValidationError => IsEditable && !IsLocallyValid();

public string FeedbackText => HasValidationError
? string.IsNullOrWhiteSpace(Value)
? "Choose a value for this action."
: $"The value is not valid. {ValueHelp}"
: ValueHelp;

public bool IsLocallyValid()
{
string trimmed = Value.Trim();
Expand All @@ -481,13 +537,21 @@ public bool IsLocallyValid()

public void Load(SwitchControlBinding binding, bool editable)
{
SelectedType = binding.Type;
Value = binding.Type == SwitchBindingType.Shortcut
? string.Join(" + ", binding.Keys ?? [])
: binding.Type == SwitchBindingType.MouseClick
? $"{binding.Value}:{binding.ClickCount}"
: binding.Value ?? "";
IsEditable = editable;
isLoading = true;
try
{
SelectedType = binding.Type;
Value = binding.Type == SwitchBindingType.Shortcut
? string.Join(" + ", binding.Keys ?? [])
: binding.Type == SwitchBindingType.MouseClick
? $"{binding.Value}:{binding.ClickCount}"
: binding.Value ?? "";
IsEditable = editable;
}
finally
{
isLoading = false;
}
}

public SwitchControlBinding ToBinding()
Expand All @@ -508,6 +572,20 @@ public SwitchControlBinding ToBinding()
return new(SwitchId, SelectedType, string.IsNullOrEmpty(trimmed) ? null : trimmed);
}

private void SetRawValue(string newValue)
{
if (string.Equals(value, newValue, StringComparison.Ordinal))
{
return;
}

value = newValue;
Changed(nameof(Value));
Changed(nameof(ValueDisplay));
Changed(nameof(FeedbackText));
Changed(nameof(HasValidationError));
}

private void Changed([CallerMemberName] string? propertyName = null) =>
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName));

Expand All @@ -522,6 +600,74 @@ private static bool IsValidShortcut(string value)
keys.Any(key => !ModifierValues.Contains(key, StringComparer.OrdinalIgnoreCase));
}

private static string DisplayValue(SwitchBindingType type, string rawValue)
{
if (type == SwitchBindingType.Shortcut)
{
return string.Join(
" + ",
rawValue.Split('+', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries)
.Select(key => OptionLabel(KeyOptions, key)));
}

return OptionLabel(OptionsFor(type), rawValue);
}

private static string RawValue(SwitchBindingType type, string displayValue)
{
if (type == SwitchBindingType.Shortcut)
{
return string.Join(
" + ",
displayValue.Split('+', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries)
.Select(key => OptionValue(KeyOptions, key)));
}

return OptionValue(OptionsFor(type), displayValue);
}

private static IReadOnlyList<BindingValueOption> OptionsFor(SwitchBindingType type) => type switch
{
SwitchBindingType.Key => KeyOptions,
SwitchBindingType.MouseButton => MouseButtonOptions,
SwitchBindingType.Shortcut => ShortcutOptions,
SwitchBindingType.MouseClick => MouseClickOptions,
SwitchBindingType.Scroll => ScrollOptions,
SwitchBindingType.Media => MediaOptions,
_ => []
};

private static string OptionLabel(IReadOnlyList<BindingValueOption> options, string value) =>
options.FirstOrDefault(option =>
string.Equals(option.Value, value, StringComparison.OrdinalIgnoreCase))?.Label ?? value;

private static string OptionValue(IReadOnlyList<BindingValueOption> options, string display) =>
options.FirstOrDefault(option =>
string.Equals(option.Label, display, StringComparison.OrdinalIgnoreCase) ||
string.Equals(option.Value, display, StringComparison.OrdinalIgnoreCase))?.Value ?? display.Trim();

private static string KeyLabel(string value) => value switch
{
"ArrowUp" => "Up arrow",
"ArrowDown" => "Down arrow",
"ArrowLeft" => "Left arrow",
"ArrowRight" => "Right arrow",
"PageUp" => "Page up",
"PageDown" => "Page down",
"Meta" => "Windows key",
_ => value
};

private static readonly BindingTypeOption[] BindingTypes =
[
new(SwitchBindingType.None, "Unassigned"),
new(SwitchBindingType.Key, "Keyboard key"),
new(SwitchBindingType.MouseButton, "Mouse button"),
new(SwitchBindingType.Shortcut, "Keyboard shortcut"),
new(SwitchBindingType.MouseClick, "Mouse click"),
new(SwitchBindingType.Scroll, "Scroll"),
new(SwitchBindingType.Media, "Media control")
];
private static readonly string[] ModifierValues = ["Ctrl", "Alt", "Shift", "Meta"];
private static readonly string[] KeyValues =
[
Expand All @@ -532,5 +678,45 @@ .. Enumerable.Range(1, 12).Select(value => $"F{value}"),
"ArrowUp", "ArrowDown", "ArrowLeft", "ArrowRight",
"Home", "End", "PageUp", "PageDown", "Ctrl", "Alt", "Shift", "Meta"
];
private static readonly BindingValueOption[] KeyOptions =
KeyValues.Select(value => new BindingValueOption(value, KeyLabel(value))).ToArray();
private static readonly BindingValueOption[] MouseButtonOptions =
[
new("left", "Left button"),
new("right", "Right button"),
new("middle", "Middle button")
];
private static readonly BindingValueOption[] ShortcutOptions =
[
new("Ctrl + C", "Ctrl + C"),
new("Ctrl + V", "Ctrl + V"),
new("Alt + Tab", "Alt + Tab"),
new("Ctrl + Shift + Escape", "Ctrl + Shift + Escape")
];
private static readonly BindingValueOption[] MouseClickOptions =
[
new("left:1", "Left click"),
new("left:2", "Double left click"),
new("right:1", "Right click"),
new("right:2", "Double right click"),
new("middle:1", "Middle click"),
new("middle:2", "Double middle click")
];
private static readonly BindingValueOption[] ScrollOptions =
[
new("up", "Scroll up"),
new("down", "Scroll down"),
new("left", "Scroll left"),
new("right", "Scroll right")
];
private static readonly BindingValueOption[] MediaOptions =
[
new("playPause", "Play / pause"),
new("nextTrack", "Next track"),
new("previousTrack", "Previous track"),
new("volumeUp", "Volume up"),
new("volumeDown", "Volume down"),
new("mute", "Mute")
];
}
}
Loading