Skip to content

test: delete the orphaned comment-fingerprint.php - #74

Merged
Ardnived merged 1 commit into
mainfrom
claude/chore-test-cleanup
Nov 2, 2026
Merged

Ardnived merged 1 commit into
mainfrom
claude/chore-test-cleanup

Conversation

@Ardnived

@Ardnived Ardnived commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Part of a test audit across all five sydevs repos, looking for tests that are no longer relevant, especially for old migrations.

Finding: the plugin has no migration tests to remove. It has no option or settings migration code at all; it first shipped in 2026-08 and every release since has only added behaviour. Every function a test calls exists, every fixture is used, and nothing is skipped.

The one dead file is tests/comment-fingerprint.php. No runner, package.json script, CI step or doc calls it. Its header says claude-workflow's comment-fingerprint.mjs shells out to it for .php, but that tool has never had a PHP path. It was a manual aid for the #27 comment sweep.

No code changes, so there is no gate to run.

🤖 Generated with Claude Code

Nothing calls it: no runner, package.json script, CI step or doc. Its
header says claude-workflow's comment-fingerprint.mjs shells out to it
for .php files, but that tool has never had a PHP path (git log -G php
shows only its creation commit). It was a one-off aid for the #27
comment sweep.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sydevs-bot sydevs-bot added the bot:working Lock: a cloud session is running on this item. Removed when it ends. label Nov 2, 2026
@sydevs-bot

sydevs-bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

🤖 no session running

recent dispatches
  • 00:59Z review-pr · attempt 1 · session · done
  • 00:59Z review-pr · attempt 1 · session

Written by the sydevs dispatcher. Sessions never edit this comment.

@sydevs-bot sydevs-bot moved this from Awaiting to Working in SYDevelopers Technical Roadmap Nov 2, 2026

@sydevs-bot sydevs-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐 Adversarial review

The diff is exactly the deletion the body claims: one file, 147 lines, nothing else added or moved.

I checked the orphan claim rather than taking it. comment-fingerprint.mjs selects files with SWEEPABLE = /\.(ts|tsx|js|jsx|mjs|cjs|mts|cts)$/ (line 344), and git log -S php on that file returns only the commit that created it. The PHP path the deleted header advertised never existed, so nothing breaks.

One exposure, reported rather than flagged. This was the only mechanical check that a translators: comment still sits immediately before its gettext call — the hazard docs/rules/code-comments.md calls a translator's only context. I ran it before the deletion: 21 comments, 15 files, 0 orphaned. After this merges nothing re-checks that adjacency, and wp i18n make-pot drops a drifted comment silently. A harm measured at zero does not earn standing code, so I am naming the choice, not asking for machinery.

Findings

None.

What was checked

  • git diff origin/main...origin/claude/chore-test-cleanup: 1 file, 147 deletions, 0 additions, 1 commit. Nothing added, so the ladder has nothing to walk.
  • Orphan claim: grep for comment-fingerprint and FINGERPRINT_ROOT across the three attached checkouts found only the file's own self-references. Absent from package.json scripts, .github/workflows/*, tests/AGENTS.md and CLAUDE.md, so no stale doc is left behind.
  • Cross-repo: read workflow/lib/comment-fingerprint.mjs whole. No PHP branch, no shell-out. Its line 431 and comment-protect.json point at lint.php and sahaj-atlas.php, both still present.
  • Ran the deleted script read-only under system PHP to measure what it guarded.
  • Body's wider audit claims: all 5 tests/fixtures/ entries are referenced, and no test in tests/*.php is skipped.
  • Reviewer profile read.

🤖 Written by the sydevs autonomous loop — see what this is


Generated by Claude Code

@sydevs-bot sydevs-bot removed the bot:working Lock: a cloud session is running on this item. Removed when it ends. label Nov 2, 2026
@Ardnived
Ardnived merged commit 04bb76d into main Nov 2, 2026
20 checks passed
@Ardnived
Ardnived deleted the claude/chore-test-cleanup branch November 2, 2026 01:04
@sydevs-bot sydevs-bot moved this from Working to Done in SYDevelopers Technical Roadmap Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants