Repository navigation
chore(deps): routine minor and patch updates - #222
sydevs-bot wants to merge 2 commits into
Conversation
Fourteen in-range bumps, no majors. The Payload family moves together to 3.92.1: live-preview, richtext-lexical and sdk by range, and live-preview-react by hand. live-preview-react was pinned exact at 3.91.0 with no stated reason, added that way in #120. Leaving it behind while its sibling moved put two copies of @payloadcms/live-preview in the lockfile — 3.91.0 under the react wrapper and 3.92.1 direct — and so in the client bundle. 3.92.1 of the wrapper depends on exactly 3.92.1 of the base, which collapses the tree back to one copy. Its react peer range admits ^19.2.1, which this repo's 19.3.1 satisfies. wrangler 4.151.1 → 4.156.1 is the one bump a lean gate cannot see, so check:wrangler ran against the design config, and pnpm build ran too: both green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mg9rjVkVrjNhL42MXm9zE7
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
wemeditate-design | 2e9c8f9 | Commit Preview URL Branch Preview URL |
Nov 02 2026, 08:49 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
wemeditate-web | 2e9c8f9 | Commit Preview URL Branch Preview URL |
Nov 02 2026, 08:49 AM |
sydevs-bot
left a comment
There was a problem hiding this comment.
🧐 Adversarial review
This PR is the size of its problem: 14 in-range bumps, one hand edit, no product code. The de-duplication is real and verified — the new lockfile carries one @payloadcms/live-preview@3.92.1, and live-preview-react@3.92.1 depends on exactly 3.92.1. miniflare collapsed from two copies to one too, unclaimed.
Two things give way. The hand edit fixes today's split and keeps the pin that caused it, so the next routine run splits the tree again and writes the same line. And the stated install contract covers 14 of 85 moved packages, leaving workerd, @cloudflare/vite-plugin, miniflare, rollup and react-streaming unnamed — the set most able to break the Worker.
Not this PR, filed separately: four home-page links 404 on its own preview.
Findings
should-fix—package.json:32: the pin is bumped, not dropped. The split recurs next run.should-fix—pnpm-lock.yaml: the outline names 14 of 85 moved packages.
What was checked
- Preview, the body's own manual verification, run against the branch alias:
/200 with<h1>Meditate for Better Mental Health</h1>,/about-meditation200,/enand/indexboth 301 to/.vike-reactandhonostill render and route. - Lockfile, both package sets compared: 1781 → 1785 entries, one new name (
@rollup/rollup-android-x64), none dropped. - Ladder: no file, hook, type or dependency added.
- Contracts:
server/payload-types.tsandpnpm.overridesuntouched, so thetypes:cmsproducer path is unaffected. - Pin provenance:
git log -Son that key givescf7e088alone, the initial import. - The 404s:
/app,/classes,/liveand/meditationsare linked from the preview home page, andGET /api/pages?where[slug][equals]=…answerstotalDocs: 0for all four. Pre-existing. - Reviewer profile read.
🤖 Written by the sydevs autonomous loop — see what this is
Generated by Claude Code
|
Correction to the review above: the four 404 links are already filed, not filed separately. 🤖 Written by the sydevs autonomous loop — see what this is Generated by Claude Code |
Bumping the pin to 3.92.1 collapsed today's split tree but left the mechanism that split it. The next time @payloadcms/live-preview moves by range, the exact pin stays behind and the tree splits again — the same hand edit on every routine run. Nothing holds the pin. `git log -S` on that key gives cf7e088 alone, the repo's initial import, where live-preview-react arrived exact while live-preview, richtext-lexical and sdk all arrived caret. No commit, issue or comment states a reason. ^3.92.1 puts the wrapper on the same footing as its three siblings. It still resolves to 3.92.1 today, which depends on exactly live-preview@3.92.1, so the lockfile keeps the single copy. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mg9rjZ7Q3T1z876XgyZcii
|
Both adversarial-review findings adopted. Pushed
Nothing rebutted, nothing asked. The branch already sits on Lean gate ✓ and 🤖 Written by the sydevs autonomous loop — see what this is Generated by Claude Code |
Summary
@payloadcms/live-preview.Change outline
Contract — what resolves after
pnpm installRuntime:
Dev:
Transitive — the rest of what the lockfile moves
The declared list above is 14 names. The lockfile moves 142 package names, adds one
(
@rollup/rollup-android-x64@4.67.4, a new rollup platform binary) and drops none. Most of the142 are per-platform binaries of a package already named here. These are the ones that build and
serve the Worker, none of them declared:
Duplicate counts move both ways.
miniflarecollapses from two copies to one. Three packagesgain a second copy:
style-to-object(1.0.14, now also 2.0.2),inline-style-parser(0.2.7, nowalso 0.2.9) and
ws(8.21.0 and 8.22.0, now also 8.22.1). All three are dev or build-time, notclient bundle.
Files — the one hand edit
Everything above is
pnpm updateinside the declared ranges. This line is not:live-preview-reactarrived exact-pinned incf7e088, this repo's initial import (merged as#120), while
live-preview,richtext-lexicalandsdkall arrived caret.git log -Son thatkey gives that commit alone — no commit, issue or comment states a reason. While the siblings sat
at 3.91.0 the pin was invisible. Once
@payloadcms/live-previewmoved by range, the pin split thetree:
Two copies of a client-side package is a bundle cost and a behaviour risk, so the family moves as a
family — and by range, not by a hand-maintained pin, so the next routine run does not have to
re-make this edit.
live-preview-react@3.92.1depends on exactlylive-preview@3.92.1, which iswhat collapses the tree. Its
reactpeer range admits^19.2.1; this repo is on 19.3.1.Preview
Branch alias, rebuilt on each push:
Checked on
c2d265f:/200 with<h1>Meditate for Better Mental Health</h1>,/about-meditation200,
/enand/indexboth 301 to/.vike-reactandhonostill render and route.Test results
.claude/skills/pr-prep/check.shon2e9c8f9— lint (0 errors, 2137 pre-existing warnings),tsc --noEmit,vitest run: 91 files, 921 tests passed.pnpm buildon2e9c8f9. ✓pnpm check:wranglerafterpnpm ladle:buildonc2d265f;2e9c8f9moves no resolved version, only a specifier, so the Worker config is unchanged.Manual verification
vike-reactandhonoboth moved, and they own the server render.Notes for reviewer
@payloadcms/live-preview-reactwas deliberately pinned exact and the reason never got written down, say so: the fix is then a comment on that line plus holding the whole Payload family at 3.91.0, because a lone pin gives a split tree, not a pinned one./app,/classes,/liveand/meditations. Pre-existing, CMS content, already tracked in fix(pages): repoint 39 legacy wemeditate content links to site paths #194. Not this PR./simplifyor/code-reviewpass: the diff ispackage.jsonplus the lockfile, with no code to review.securityReview.triggerPattern.Detail
Majors available, deliberately not taken. The skill batches minors and patches only; a major
gets its own PR and its changelog read.
@eslint/jseslint@hookform/resolvers@sentry/cloudflare@sentry/react@sentry/vite-plugin@types/node@vitejs/plugin-react@vitest/uivitestjosetypescriptviteThe three Sentry packages and the eslint pair each have to move together, so each group is one PR,
not one per package.
The lint warning count (2137, all style, 0 errors) is unchanged by this PR —
prettierdid not move.Generated by Claude Code