fix: locate apk in agp 9 output dir - #203
Open
guzino wants to merge 1 commit into
Open
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs synonymdev/bitkit-android#1128
Refs synonymdev/bitkit-android#1127
This PR points the Android build helper at the APK directory produced by the AGP 9 build.
Description
AGP 9 removes the legacy variant APIs that renamed APKs inside AGP's own output directories, so synonymdev/bitkit-android#1127 leaves those outputs under their default
app-*names and writes the establishedbitkit-*names as copies underapp/build/outputs/bitkit/<variant>. The helper's lookup inapp/build/outputs/apk/<flavor>/debug/returns no file against that build and exits before staging anything.APK_FLAVOR_DIRwithAPK_VARIANT_DIR, using the Gradle variant namesdevDebugandmainnetDebug.app/build/outputs/bitkit/$APK_VARIANT_DIR.bitkit-*-universal.apkglob and the stagedaut/bitkit_e2e.apkandaut/bitkit_e2e_mainnet.apkfilenames unchanged, so no downstream E2E configuration moves.QA Notes
Manual Tests
./scripts/build-android-apk.shagainst chore: upgrade to agp 9 and configure parallelism bitkit-android#1127 → stagesaut/bitkit_e2e.apkfrombitkit-dev-debug-187-universal.apk.BACKEND=regtest ./scripts/build-android-apk.sh→ stagesaut/bitkit_e2e.apkfrom the same universal APK.BACKEND=mainnet ./scripts/build-android-apk.sh→ stagesaut/bitkit_e2e_mainnet.apk. I could not run this: the checked-ingoogle-services.jsonhas noto.bitkitclient, so the mainnet build stops before the lookup. The mainnet branch changes the same single path.regression:full E2E run against the AGP 9 branch → suites resolve the staged APK as before.Automated Checks
bash -npasses and noAPK_FLAVOR_DIRoroutputs/apkreference remains in the script.