Repository navigation
Monochrome menu bar icon, click-to-open, real .app bundle - #10
Merged
Merged
Conversation
Three real gaps found live testing bpm-tray: 1. The tray icon used the full-colour app logo via SetIcon - rendered as an illegible colour blob at actual menu bar size. Generated a proper macOS 'template' icon (assets/logo-template.png): flat black silhouette with real alpha, cropped and downsized from the same source logo via ImageMagick (fuzzy black->transparent, recolour remaining pixels solid black, trim, resize). Wired via SetTemplateIcon so macOS tints it correctly for light/dark menu bars. 2. Clicking the icon required navigating a dropdown menu just to open the web UI. fyne.io/systray's SetOnTapped fires directly on left-click instead of showing the menu (confirmed by reading systray_darwin.go: tappedLeft, if set, is called instead of show_menu()). Wired left-click to open the browser directly; right-click still shows the menu (status + Quit), since SetOnSecondaryTapped is left unset. 3. Running bpm-tray meant launching a bare Mach-O binary from a terminal - no Spotlight, no Launchpad, no /Applications entry. Added packaging/macos/Info.plist.template and a release.yml step that assembles a real BpmTray.app (LSUIElement so it never shows a Dock icon, proper AppIcon.icns built from the same logo via sips+iconutil) and zips it per-arch as an additional release asset, alongside the existing raw binary tarball. Verified locally end-to-end: built, zipped, unzipped fresh, launched via `open BpmTray.app` (the same path Finder/Spotlight take), confirmed the server responds and the process never appears as a foreground/Dock app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Applicationsinstead of being a bare terminal binary.Test plan
go build ./...,go vet ./...,go test ./...all passopen BpmTray.app(same path Finder/Spotlight take), confirmed the server responds and no Dock icon appears