Repository navigation
chore(omni): align cluster template talos.version with the installer - #10
Merged
Merged
Conversation
The talos-images upgrade workflow rewrites omni/talos-image.yaml and omni/machine-classes/*.yaml, but never omni/cluster-templates/talos.yaml. The template has therefore drifted: it pinned Talos v1.12.5 while the machine classes install v1.12.6, and it is the file Omni actually applies. Move it to v1.13.5 to match PR #9. kubernetes.version is left at v1.32.3 on purpose and annotated: it is human-owned, and Talos 1.13.x still supports it.
syscod3
added a commit
that referenced
this pull request
Aug 8, 2026
…10) The talos-images upgrade workflow rewrites omni/talos-image.yaml and omni/machine-classes/*.yaml, but never omni/cluster-templates/talos.yaml. The template has therefore drifted: it pinned Talos v1.12.5 while the machine classes install v1.12.6, and it is the file Omni actually applies. Move it to v1.13.5 to match PR #9. kubernetes.version is left at v1.32.3 on purpose and annotated: it is human-owned, and Talos 1.13.x still supports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drift
The
talos-imagesupgrade workflow rewrites exactly two things in this repo:It has never touched
omni/cluster-templates/talos.yaml— and that is the file Omni actually applies. So the template silently fell behind:omni/cluster-templates/talos.yaml(applied)omni/machine-classes/*.yaml(auto)omni/talos-image.yaml(auto, informational)What this changes
talos.version→v1.13.5, matching the installer #9 introduces. Both version fields are now annotated with who owns them.What this deliberately does not change
kubernetes.versionstays atv1.32.3.Talos v1.13.5 declares
DefaultKubernetesVersion = 1.36.2andSupportedKubernetesVersions = 6, i.e. it supports k8s 1.31 → 1.36. So v1.32.3 remains valid and the Talos bump does not force a k8s upgrade.Going to 1.36 is a four-minor jump, which Kubernetes' +1-minor policy does not support. It needs stepping (1.32 → 1.33 → 1.34 → 1.35 → 1.36), each applied and verified, and it should start from the cluster's actual running version rather than what this file claims.
Note on blast radius
Merging does not deploy. This repo's CI is yamllint / gitleaks / kubeconform / helm-lint — no
omnictl. The machine classes are annotated "Applied manually in Omni UI". Argo's app-of-apps syncs onlyinfrastructure/*/application.yaml, so nothing underomni/is in its scope.