Repository navigation
fix(imp): tolerate control-plane taint on operator - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Imp operator can now schedule on both ordinary control-plane nodes and the dedicated runner node while retaining its existing runner taint tolerance. This removes the scheduling gap that left the second operator replica Pending when only the non-runner control-plane nodes were eligible.
The change adds the exact
node-role.kubernetes.io/control-plane/Exists/NoScheduletoleration to the operator values only. Agent and runtime placement, image digests, and both pinned Imp source revisions are unchanged.Validation
ca0e86a1d2490ac0d2c08a2a5151534c8b805224: operator renders both tolerations; agent/runtime pod specs and all rendered image references are unchanged.python3 scripts/validate.py— passed (canonical validator; local environment noted that kubeconform was unavailable).python3 scripts/check-version-drift.py --selftest— passed.python3 scripts/check-version-drift.py— passed.