Repository navigation
Add an optional workflow that runs the tests on a simulated H100 - #18
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 90.65% 90.65%
=======================================
Files 14 14
Lines 867 867
Branches 18 18
=======================================
Hits 786 786
Misses 71 71
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Hi saqibkh, thanks for the effort. I agree that it is necessary to add a test workflow for Hopper GPUs. I just merged this commit into main branch so I will close this PR soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing CI (
coverage.yml) builds cuSZp and runsctest -V || trueon a hosted runner with no GPU, so the sixcuSZp_test_*programs cannot work there and any failure is ignored. This adds a separate, optional workflow.github/workflows/gpu-sim.ymlthat builds cuSZp and runs those tests on a simulated NVIDIA H100, using PantheonSim (via thepantheongpu/setup-pantheonsimaction, pinned by SHA). I am the author of PantheonSim, so please weigh this accordingly.It does not touch
coverage.ymland is not meant to be a required check. A simulator cannot reproduce hardware-specific behavior or timing, so it complements real-GPU testing and does not replace it.What it does:
CMAKE_CUDA_ARCHITECTURES=90-virtualandCMAKE_CUDA_RUNTIME_LIBRARY=Shared(the simulator runs PTX only and needs a shared CUDA runtime), builds and installs.cuSZp_test_{f32,f64}_{1D,2D,3D}undervgpu run. No|| true: the job fails if a test exits non-zero or if any of the three modes (fixed, plain, outlier) does not printPass error check!. This check is needed because the test programs printFail error check!but always return 0.sed(not committed) to use 64M elements (256 MB f32, 512 MB f64) and 3D dims{512, 512, 256}. No change to the project is needed.workflow_dispatchandpull_requestlimited tosrc/,include/,examples/,cmake/,CMakeLists.txtand the workflow itself. A concurrency group cancels superseded runs, withpermissions: contents: read.What is left out:
Result on a fork: the run passed. The whole job took about 18.5 minutes on a first run, of which about 15.5 minutes was the action setting up the simulator. The build took 30 seconds and the six tests about 2 minutes 10 seconds.
Run: https://github.com/saqibkh/cuSZp/actions/runs/42454833424