Skip to content

difftest: surface.surface_p9 analytic diagonal regressions - #1041

Merged
bherbruck merged 5 commits into
tangency-labs:mainfrom
altvnk:fix/surface-p9-analytic-diagonals
Oct 26, 2026
Merged

bherbruck merged 5 commits into
tangency-labs:mainfrom
altvnk:fix/surface-p9-analytic-diagonals

Conversation

@altvnk

@altvnk altvnk commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Scoped completion evidence

Units: surface.surface_p9.

Four named real-cylinder/canonical-cone regression fixtures exercise the existing
FindTessellationSplits diagonal continuation in direction U. No production
geometry or representation was added. Each kind has identical enabled/disabled
controls: fractional domain [0.125,0.2,0.375,0.8], controls [0.05,15,0].

Expected edits (exact):

  • fixtures/surface.surface_p9/analytic-diagonals.json
  • crates/difftest/src/units/surface_surface_p9.rs

Published head and verification

Head d8d3972f7939a733135ed630c6d1536a7fea929b, safely synchronized with authoritative main b52ba92814f3d72d1008270df84b19cbd2e6c896.
Latest upstream observed at publication: b52ba92814f3d72d1008270df84b19cbd2e6c896.
Independent final source review: no findings, fingerprint 4d240e3afa68b30a4250399e765f4122bf01da30b5f44dd06e7e29c950691c5d.
Reviewed binary PR diff unchanged across both safe upstream merges; all 221 old
fixtures, minimum 600 generated cases, generator inputs/RNG/seeds, native guards,
formulas, tolerances and floors are unchanged. Total stored fixtures:225.

Local macOS Rust1.98/CPP checks on this exact head:

3 focused CPP tests passed
PASS surface.surface_p9 cases=825 passed=825 failed=0 deferred=0 max_rel_err=0e0 with_values=825 no_values=0 vacuous=0
SENSITIVE surface.surface_p9 perturbed=825 detected=825 unperturbed=0 deferred=0
CPP-enabled target Clippy --all-targets -D warnings: PASS
cargo fmt --all --check; git diff --check: PASS

Shared reference libraries were reused read-only, with hashes/mtimes unchanged;
pinned upstream is c9c5979. This local from-source reference has no BUILDINFO/key
marker and is not canonical Linux CI proof.

Operation / cases Implementation Successful native comparison Remaining gap
Existing cylinder/cone U diagonal continuation; analytic_diagonal_cylinder_u_enabled, analytic_diagonal_cone_u_enabled Existing real analytic surfaces and CrvOnSurf retained; new fixtures/tests only Each engine succeeds with nine finite ordered in-domain splits; all nine values plus status compare, max relative error0 This bounded U/subdomain case only; other analytic kinds/directions not newly demonstrated
Matching _u_disabled controls Existing operation unchanged Two endpoints plus status compare for both kinds Controls do not establish other branches

The focused CPP test also perturbs an interior split while preserving status;
the unchanged comparator detects exactly one mismatch. Existing generated
cylinder/cone suppression remains executable-byte-identical; only its stale
comment was corrected. No shim/FFI/plan/fixture-removal or guard changes.

Related work and status

#1031/#1042 curve/cache interfaces remain untouched. #1047 p6 Sphere, #1048 p4
Ellipse equations and #1049 p7 Ellipse classification are independent unit scopes.
Available follow-ups: other kinds/directions and broader generator coverage are not
reserved or certified by these four cases.

Ready for review by explicit user instruction; canonical CI is still pending., including
native sweep, perturbation, value-share and exact-base retention. Source success,
synthetic queue checks and actual merging are separate. Maintainers retain workflow
authorization, approval, queue admission and merging.

Metadata-only upstream status correction synchronized before canonical validation; all five local checks reran successfully on the resulting exact head.

User-authorized review status

Marked ready for review at the user’s request after local native validation and independent source review. Canonical CI was authorization-blocked at the latest audit; this transition does not claim green CI, approval, queue admission or merge readiness. Maintainer workflow authorization and all required checks remain mandatory. No source commit or workflow configuration changed.

Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
altvnk and others added 2 commits October 26, 2026 00:12
Add named cylinder and cone controls that exercise the existing diagonal
continuation and compare complete native split arrays. Preserve old fixtures,
generator inputs, guards, numerical formulas and tolerances.

Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
altvnk and others added 2 commits October 26, 2026 00:26
Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
@altvnk

altvnk commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@bherbruck — reviewed draft head d8d3972f7 passed local exact-head 3 focused CPP tests, full native surface.surface_p9 825/825 cases, perturbation825/825, CPP-enabled Clippy and formatting. All221oldfixtures, existing generator inputs/seeds/min600, guards and tolerances are preserved. Canonical run40245288030 requires authorization and has executed zero jobs. Please inspect/authorize it; the PR remains draft pending all13 canonical jobs, including native/value-share/exact-base retention. No technical CI failure or merge-readiness claim.

@altvnk
altvnk marked this pull request as ready for review October 26, 2026 00:38

@bherbruck bherbruck left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by the automated first-pass review: CI green, mergeable, no CI/build/dependency file changes, no red-flag patterns in added code (process/network/env/unsafe outside FFI/blobs/hidden unicode), 0 known-mismatch entries added. Logic is gated by CI and the difftest merge queue.

@bherbruck
bherbruck added this pull request to the merge queue Oct 26, 2026
Merged via the queue into tangency-labs:main with commit a783c4d Oct 26, 2026
13 checks passed
@altvnk
altvnk deleted the fix/surface-p9-analytic-diagonals branch October 26, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants