Repository navigation
fix: preserve rotational surface geometry and production cleanup - #615
Merged
bherbruck merged 7 commits intoOct 23, 2026
Merged
Conversation
Use PrimitiveModel's existing face constructors and retain original status/state fields. Compare owning topology counts and actual vertex, curve and surface samples for successful builds; keep the remaining DeleteFaces continuation deferred. Co-Authored-By: Codex <noreply@openai.com>
Forward the production model's face deletion through the landed caller-keyed intersector. Detach the revolution API's actual first owned surface, matching the native GetSurfaces/SetOwner sequence, and compare its domain plus virtual point samples instead of rejecting successful output. Primitive p3 now has 295 exact native passes and no deferrals; sweep API gains 17 passes with three honest downstream deferrals. Preserve all old comparable records, guards and tolerances. Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Keep main shared face/axis defaults and consumed-curve slot semantics, while preserving production notification-aware deletion and native geometry comparisons. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
tdamsma
changed the title
tdamsma
marked this pull request as ready for review
October 23, 2026 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Machine-generated (OpenAI Codex coordinator and agents) on behalf of @tdamsma.
Detach the actual generated revolution surface, preserving its geometry metadata, and use the production model's caller keys for face cleanup. Compare vertex positions and sampled edge/face geometry against C++.
Refreshed against main, preserving its shared face/axis adapters and consumed-curve behavior. Five affected native suites pass without lost comparisons: primitive p3 has 295 passes and no deferrals; surface sweep has 879 passes and three deferrals.
At
451474ecb, all seven canonical CI checks pass, along with local strict CPP Clippy, 2,064 kernel tests, wasm and formatting. No tolerances or guards changed.