Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claim. Since #541, the topology solver classifies points on faces read-only. Where a visited edge use has no UV trim, it stops with
Unported { "SmEdgeuse::GetOrCreateUVTrimCurve (unprepared read-only topology)" }; the C++ creates that trim lazily insideSmLoop::ContainsUVPoint. #613 makesshell::ray_firerequest the trim and retry. This PR extends the same mechanism (RayPreparation,QueryTopology::Requested) to the other entry points that reach the refusal:brep::p2::ray_fireBrepQuery::classifyboundary solvebrep_curve_solvesites (IntersectorBrepgets a way to create the trim)query::api_queries(read-only&dyn TopologyObjects; the caller retries)Prototype measurements against the C++ (pinned c9c5979, 1e-9 unchanged): every one of these cases passes or moves to an unrelated unported symbol, with 0 failures, once #618's harness owner fix is in.
Depends on #613 (built on its branch, coordinated in #613 (comment)) and #618.
🤖 Generated with Claude Code