Repository navigation
port: geom.grid - #620
Merged
Merged
port: geom.grid#620
Conversation
Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
Add six affine surface/cache cases and unit-local native grid observations while preserving the original 615 inputs and both opaque deferrals. Add canonical-CI identity, node-validation and mutation-sensitivity controls. No production paths or tolerances change. Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed — user-approved harness-only scope
Head:
2efc98e06, based on authoritativeupstream/main7935b4c09b72a341a8e994c0f27d57f7a0f0b97f.SmSurfaceHierarchyElement::ExpandHierarchy, andSmGrid::AddElementwith validated cache-owned node ordinals.Preserved invariants
Static checks establish that
fixtures/geom.grid/cases.jsonand the complete legacy generator region are byte-identical to the base. All 15 old fixtures and 600 old generated inputs remain. Legacy opcodes keep their opaque semantics: the original object-7 and node-0 cases are not fixed and must remain deferred. No tolerance, absolute floor, existing output, generator, or unit status is changed. Merged #612 / closed #607 remain untouched.Canonical CI 39964563449 completed successfully on exact head
2efc98e065f92d852dd0cb7e0449a583cb1d19ae(all seven jobs).All six new cases pass substantive native comparisons; the original 613 passes and original two deferrals remain. Canonical runner tests passed all six new tests, including stable-owner separation, actual cache-node rejection, the original deferrals, corpus preservation, and mutation detection for skipped expansion/wrong identity/corrupted normal. Runner-test summary: 264 passed, 0 failed, 32 ignored (none of this change’s tests ignored).
Validation / review boundary
Passed locally: explicit-path rustfmt check, staged diff check, JSON/schema and seven-path scope checks, byte-preservation checks. Per authorization, no local Cargo/native builds, native tests, C++ fetching, dependency work, or full-suite run occurred. Native parity and mutation-sensitivity tests passed in the exact-head canonical run above.
Independent review found no blocking findings within the explicit bounded affine input family and verified all seven exact-head CI jobs. Approved for PR ready status only. geom.grid remains partial: these are six NEW affine cases, not recovery of the original two deferrals. No general curved-cache coverage is claimed. No code, commit, push, unit-status, merge, queue or cleanup action accompanies this readiness change; the lane, branch and evidence are retained.
Co-Authored-By: GPT-6.1 Sol Fast noreply@openai.com