Repository navigation
port: query.poly - #621
Merged
Merged
port: query.poly#621
Conversation
Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
…ases Add an opt-in real-face resolver and port the native UV/pole/seam degeneracy continuation. Compare real SmFace surfaces, independent mapped samples, and native IsDegenerate decisions in 16 new fixtures (27 calls). Preserve the original generator and opaque-owner paths; no tolerance or unit-status changes. Co-Authored-By: OpenCode (GPT-6.1 Sol Fast) <noreply@openai.com>
Forward only the public SmObject context allocator and matching ordinary/placement deletes, avoiding SmTopology's hidden allocator and SmObject's private overloads. No geometry, protocol, guard or fixture changes. Co-Authored-By: OpenCode (GPT-6.1 Sol Fast) <noreply@openai.com>
Use checked first-row access with the existing harness error, terminate the unit-returning mutation arm, and merge only identical expected-result patterns. No geometry, fixture, generator, guard or comparison changes. Co-Authored-By: OpenCode (GPT-6.1 Sol Fast) <noreply@openai.com>
Sync with verified main 27b698e before the approved documentation-only clarification. Co-Authored-By: OpenCode (GPT-6.1 Sol Fast) <noreply@openai.com>
Document that upstream ignores evaluation statuses while the owner-aware method propagates errors. Remove unsupported claims about undefined native points; no runtime changes. Co-Authored-By: OpenCode (GPT-6.1 Sol Fast) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Add explicit real owning-face geometry to
query.poly: RustBrep/FaceIdresolution, nativeSmFace/SmPlane/BezierSmBSplineSurfacedegeneracy decisions, and independent mapping/pole/seam/identity controls. The legacy opaque-label path is retained without invented geometry.Five paths versus authoritative main:
crates/solidcore/src/query/poly.rscrates/solidcore-ffi/src/units/query_poly.rscrates/difftest/src/units/query_poly.rsharness/cpp/shim/query_poly.cppfixtures/query.poly/real_owners.jsonExact-head verification
Tested head:
537a20ac9ed5beb3a1fe6e948f0a24d0d9ba0091.Canonical CI 39971909395: 7/7 jobs successful, including C++ Clippy, native difftest, runner tests, kernel tests, fmt, wasm, deny and publish dry-run.
Passed at this head:
owner_tests::original_corpus_and_opaque_native_outputs_are_retainedowner_tests::real_owner_native_mapping_poles_seams_and_controlsquery::poly::tests::degeneracy_resolves_real_face_but_not_an_opaque_keyOriginal 671 cases = 669 passes + the same 2 unresolved-owner deferrals (
gen0378,gen0496), including unchanged native four-element-9outputs. Added 16 explicit-owner fixtures / 27 native degeneracy calls. Original fixtures, generator, inputs and guards retained; strict1e-9relative tolerance, no absolute floors.Sync and limits
Authoritative live main
27b698e905f033b4a6a96548fbc65b2bfae04294is an ancestor through attributed mergead1e8771fb98e141cbdc3d043607cfaafc2e2f70; clean worktree, clean mergeability and five-path scope verified before readiness. The final commit changes only two documentation comments, with no runtime changes.Documented deviation: upstream ignores surface-evaluation statuses; the owner-aware Rust method propagates evaluation errors. No unsupported claim of undefined native points.
query.polyremains partial, not green. No schema/guard/reference/tolerance/floor/plan-status edits, local compilation/native/tests, CI rerun, merge-to-main or queue action.