Repository navigation
port: blend.fillet_intersector - #622
Merged
bherbruck merged 6 commits intoOct 23, 2026
Merged
Conversation
Co-Authored-By: GPT-6.1 Sol Fast <noreply@openai.com>
Add unit-local native-feature checkpoints around the genuine plane solve, StepSolve return and ComputePointValues. Keep supplemental span reconstruction explicitly separate, and require instrumentation to preserve each original 189-value record bit-for-bit. Co-Authored-By: OpenCode GPT-6.1 Sol Fast <noreply@openai.com>
Use the pinned getters' public UV matrix fields without casts or point copies. Make unit-local Rust probe helpers fallible and checked while retaining checkpoint payloads, successful evaluation order and the per-side original-record bit-identity gates. Co-Authored-By: OpenCode GPT-6.1 Sol Fast <noreply@openai.com>
Remove optional post-operation span reconstruction and its private snapshot dependency. Retain genuine delegating observers, tags 1 through 4 and both original 189-value per-side bit-identity gates. No corpus, exception, production, reference or tolerance changes. Co-Authored-By: OpenCode GPT-6.1 Sol Fast <noreply@openai.com>
Enclose review_cases.json#72 in backticks in the existing diagnostic header. No diagnostic, corpus, comparison, or production changes. Co-Authored-By: OpenCode GPT-6.1 Sol Fast <noreply@openai.com>
Integrate verified authoritative main without changing the diagnostic-only scope. Co-Authored-By: OpenCode GPT-6.1 Sol Fast <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic-only scope
Actual-call observations for unchanged
review_cases.json#72(rv_next_clipped_step), limited to five owned runner/FFI/shim/support paths. No reconstruction or production/reference changes. Original fixtures, generator, 189-value serialization/comparisons, known-mismatch exception, guards,1e-9relative tolerance, empty absolute floors and unit plan status are preserved. This is not a numerical fix or unit promotion.Current verified head
6514e96a3c2b47a7e577e8d5541618f4731a1109.mainat27b698e905f033b4a6a96548fbc65b2bfae04294; final freshness check confirmed that same tip.Four actual observations
point.uv_curve_pv[0][0].y: C++-0.09999999999999992, Rust-0.1(six ULPs; below1e-9relative). Other intermediate matrix/position fields also differ.ComputePointValuesoutput1e-9relative; additional intermediate matrix/position differences are no longer present.Root cause remains unproved. These observations do not establish causality for the final deviation mismatch. Internal plane-solve operations,
LocalCurveIntersect, Hermite and span calculations remain unobserved; intermediate/inactive fields are not automatic root-cause evidence.Unchanged native corpus
Native difftest job 120477606398:
The original strict-gate mismatch and exception remain unchanged; the unit stays partial. Any numerical fix requires separate causal evidence and approval.