[embed-3d]

The rest of #556, after #628 (edges, merged). Rust now runs the destructors that send SM_NO_DESTRUCTION where it deletes their records, each followed by ~SmAObject's ClearAttributes.

Changes

• New helpers. Each notifies Notify(SM_NO_DESTRUCTION, this, NULL, NULL) through the object's context (GetContext(): the environment's context, else the kernel's). The notification status is ignored; Unported propagates. Then the record is dropped with what it owns, and ClearAttributes runs.
  • topology::edgeuse::p2::destroy for ~SmEdgeuse (SmEdgeuse.cpp:74)
  • topology::face::p3::destroy for ~SmFace (SmFace.cpp:87)
  • topology::shell::destroy for ~SmShell (SmShell.cpp:47)
  • edge::destroy from fix: edge destruction notification and attribute cleanup in DeleteEdge / GlueEdgesGeneral (#556) #628 now shares the context binding (edge::with_object_context).
• brep_p4:
  • DeleteEdge: its edge uses and the face a manifold delete merges away.
  • DeleteVertex: its vertex shell.
• brep_p5: the shells GlueVertices deletes.
• brep_p3 DeleteFace now deletes what upstream deletes (SmBrep.cpp:7072-7546):
  • the easy branch's edge uses, which it only unlinked before (delete pEU; delete pEUMate)
  • the other shell of a region merge (delete pOtherShell)
  • the emptied shell (delete pShell)
  • the last new shell of the nesting pass (delete pLastNewShell)
  • destroy_face now also clears the face's attributes.
• Not modelled: objects without a notifying destructor (face uses, loops, loop uses, vertices, vertex uses, regions) are removed without ClearAttributes. The whole-B-rep destroy is unchanged. Both are documented in brep::p4's module docs.

Native comparison

The topology.brep_p3 recorders (shim and runner) count SM_NO_DESTRUCTION per caller kind: edge, edge use, face and shell. DeleteFace records end with the four counts.

• All 90 delface cases agree.
• Counter-check: with only the brep_p4 changes, 23 failed (edge use 8 vs 4, shell 2 vs 1, …). After the first DeleteFace round, 3 still failed on the last-new-shell deletion, now fixed.

Tests

edgeuse_shell_and_face_destructors_notify_and_clear_attributes uses a wire edge use, its wire shell and a face, all sharing one reference attribute with a surviving edge:

• Each destructor sends one destruction per callback.
• The records leave their arenas.
• Only the survivor stays an attribute user.

Difftest (macOS arm64, pinned c9c5979)

Full run over every green/partial unit except topology.brep_data (macOS hang, #450), compared unit by unit with main's CI reports (run 39982203560, b35cd5ac7):

• No unit changed its pass/fail/deferred counts, apart from the known macOS/arm64 failures (difftest on arm64: geom.hash_table and heal.heal_data_p1/p2/p3 fail because upstream's (ULONG)double UB saturates instead of wrapping #448, Upstream use-after-free in SmBSplineCurve::DeformToEndPointTargets (SmBSplineCurveNLib.cpp:3138) makes curve.curve_p6 / nurbs.b_spline_curve_n_lib deform cases fail on macOS #449, difftest on macOS: libc++ istream extraction breaks the ASCII-reader units (database_io abort, brep_data hang, srf_in_volume read_db) #450), which fail identically on unmodified main.

After merging main 246172b5e:

PARTIAL topology.brep_p3 cases=897 passed=812 failed=0 deferred=85 max_rel_err=0e0
PARTIAL topology.brep_p4 cases=327 passed=290 failed=0 deferred=22 max_rel_err=0e0
PARTIAL topology.brep_p5 cases=797 passed=785 failed=0 deferred=12 max_rel_err=0e0
PARTIAL topology.brep_p7 cases=348 passed=285 failed=0 deferred=63 max_rel_err=0e0
PASS heal.stitch_p1 cases=300 passed=300 failed=0 deferred=0 max_rel_err=0e0
PASS heal.stitch_p2 cases=556 passed=556 failed=0 deferred=0 max_rel_err=0e0

Also run: cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, the same with -p difftest --features cpp, cargo test -p solidcore (2063) and the wasm check. No tolerance or guard changed.

Overlap: #613 and #335 edit other hunks of brep/p3.rs, p4.rs, p5.rs and shell.rs (stitch_faces, stitch_and_orient, ray-world code).

🤖 Generated with Claude Code

https://claude.ai/code/session_01TYEpC4tUKxEP3MCaFL5Kz2