Repository navigation
wire: SmBrep::Transform (blend.hcr, merge_p1 runner) and UpdateVertexEdgeIntervals (brep_p5) - #679
Merged
bherbruck merged 4 commits intoOct 23, 2026
Conversation
… runner Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- blend::hcr: Hcr::with_transform transforms the scene copy with topology::brep::p5::transform_with_notifications (no scale, scaled tolerances) under the scene's notification environment, as SmHCR::ConstructorInit. - boolean.merge_p1 runner: the SmTemporaryBrepTransform probe applies and restores its shift through topology::brep::p5::transform (+2 pass). - topology::brep::p5: CombineCoincidentVertices ends with the ported topology.brep_p1 UpdateVertexEdgeIntervals (SER, as upstream) instead of the UNPORTED stub (+8 brep_p5, +13 topology_intersector_p2, +6 topology_intersector_p3; 3 brep_p10 cases now defer further on). - boolean.topology_intersector_p3 runner: handles and state are numbered by a post-merge re-walk of both B-reps (Canon::reachable, the shim's walk_all), so records a squeeze deleted, which the Rust arena keeps unlinked, read as unknown on both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cr-merge # Conflicts: # plan/units/blend.hcr.toml # plan/units/boolean.merge_p1.toml # plan/units/topology.brep_p10.toml # plan/units/topology.brep_p5.toml
…transform The model fixture's hcr() now builds the transformed scene and stops at the fixture's missing retained HCR service instead of the SmBrep::Transform stub. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brett19
marked this pull request as ready for review
October 23, 2026 23:10
brett19
added a commit
to brett19/solidcore-fork
that referenced
this pull request
Oct 23, 2026
…ll ray face geometry branch Only conflict: plan/units/topology.brep_p10.toml notes; kept tangency-labs#679's UpdateVertexEdgeIntervals update and tangency-labs#613's update text. Code merged cleanly (topology/brep/p5.rs included). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires three remaining stubs to code that is already ported:
blend::hcr:Hcr::with_transformnow transforms the scene copy withtopology::brep::p5::transform_with_notifications, asSmHCR::ConstructorInitdoes withTransform(m_vViewTransform)(no scale,bScaleTol=TRUE, status ignored). It notifies through the scene's environment.SmTemporaryBrepTransformprobe (op 7) applies and restores its shift throughtopology::brep::p5::transform.topology::brep::p5:CombineCoincidentVerticesnow ends with the portedtopology::brep::p1::update_vertex_edge_intervalsunder the caller's notification environment (SER, as upstream), replacing theUNPORTED(topology.brep_p1)stub. The change is a few lines at one call site.walk_all) and numbers every handle and the state by that walk. Objects a squeeze deleted read as unknown. The Rust side now does the same withCanon::reachable(from the boolean.merge_p1 runner), so deleted records, which the Rust arena keeps unlinked, are unknown on both sides. This is a harness representation fix; no tolerance or case changed. Without it, the 6 newly reached cases differed only in arena counts and handle numbering.Overlap: #613 (henlamp) and #678 (claim on topology.brep_p5) both touch
topology/brep/p5.rs. This PR's p5 change is limited to thecombine_with_notificationstail and the removed stub.difftest (before = main CI d7abe91, after = this branch)
No unit is promoted: each still has other deferrals.
🤖 Generated with Claude Code