Repository navigation
Conversation
fkirill
force-pushed
the
fix/521-topology-evaluation-status
branch
from
October 24, 2026 02:22
016f4a1 to
9ccb0da
Compare
fkirill
force-pushed
the
fix/521-topology-evaluation-status
branch
from
October 24, 2026 02:51
8d7a896 to
2514779
Compare
fkirill
force-pushed
the
fix/521-topology-evaluation-status
branch
from
October 24, 2026 04:10
2514779 to
db87b73
Compare
fkirill
force-pushed
the
fix/521-topology-evaluation-status
branch
2 times, most recently
from
October 24, 2026 04:46
ae5abf5 to
021665c
Compare
Contributor
|
@fkirill a heads-up: I have a change ready that touches It splits 🤖 Generated with Claude Code |
Author
|
@erlis No worries, happy to rebase either way. |
Co-Authored-By: Codex <noreply@openai.com>
…s#521) Require successful curve reversal, tangent/angle evaluation, UV-corner/gap queries and surface derivatives before consuming their outputs. Preserve ClassifyLoops errors and retry incomplete healing stages. Seven regressions failed before their fixes. Record the unchanged C++ reference's 43 lost-angle statuses and four failed-stage marker differences explicitly; preserve all prior known records and comparison tolerances. Co-Authored-By: Codex <noreply@openai.com>
Record the measured 471 unported deferrals and 37 UB-137 native crash guards separately. Production code, fixtures and all comparison results are unchanged. Co-Authored-By: Codex <noreply@openai.com>
Keep tangency-labs#704 implementation and coverage. Remove only proven obsolete vertex exceptions; retain six remaining failure/retry regressions and four explicit healing differences. Co-Authored-By: Codex <noreply@openai.com>
fkirill
force-pushed
the
fix/521-topology-evaluation-status
branch
from
October 24, 2026 20:45
021665c to
297add0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed Hermite reversal used to overwrite its wire edge interval with
[1e20,-1e20]and flip its uses. Propagate failures before consuming output or editing edge topology. Loop UV corners, edge-use loop gaps/deviation and healing classification preserve their failed statuses too; an incomplete Stage3 resets its marker so retry cannot appear cached.Follow-up to #521 after #704 landed. #704's vertex contract, regression and 70 fixtures are preserved exactly. This PR's vertex error policy and one regression were removed. All 43 former vertex exceptions were proven matching, removed individually, and the full 5,598-case vertex unit then passed strictly. The 20 constant-angle/control fixtures remain parity coverage.
heal.face_propsstays partial.Validation on
0cdc106a4a941c31be2f48402084dca3a72832f0:-D warnings, 2,094 kernel unit tests, wasm and 48 runner tests pass. Five integration tests pass under the same optimized profile now used by CI; one existing partial-sphere/torus case remains ignored.plan/findings.md.Scope:
ContainsUVPointalready handles failed evaluations safely;HasDogLegNearPoleis unported. This remains a draft awaiting maintainer approval for canonical CI; full macOS --green is not claimed because of the reference issues #448–450.GitHub’s reported conflict after main’s region-nesting cleanup is resolved on
0d99454881b00467325d4ced11593dfaba9f5200. Fresh fmt, kernel Clippy with warnings denied, 2094 kernel unit tests (--lib) and wasm pass. Implementation, C++ shim and fixture blobs are byte-identical to the preceding validated revision. All 8 current main records and 4 issue-specific records are retained; obsolete main records are not restored. Own records precede the unchanged main header to keep later head deletions and tail additions independent. Native comparison figures above remain attributed to their stated earlier bases; standalone native comparisons were not rerun for this metadata conflict repair. Canonical CI remains pending maintainer approval.Rebased onto current main
2ca17d8e9963483d46ab53e7e52743a6dfc4345con 2026-10-24, published as297add048cc4b0eeaed9fd9d32e90fb54453aa7a. Conflicts were confined toplan/units/topology.edge.tomlandplan/units/topology.edgeuse_p1.toml; both upstream coverage notes and this PR's historical validation were retained. The four modules' added/removed source lines match the previous PR exactly, the vertex fixture corpus is byte-identical, and upstream's edge owner-key update is retained. Fresh formatting, default workspace/all-target Clippy with warnings denied, 2,115 kernel unit tests (--lib), and wasm check pass. Native comparisons were not rerun for this plan-note conflict resolution; their figures above retain their original validation bases. The cache-wrapper refactor described in the coordination comment is not on this main revision yet. Canonical CI remains pending maintainer approval.