Repository navigation
fix: sweep store records face tolerances on the surfaces it owns - #712
Merged
Merged
Conversation
SweepStore::insert_body owns each face surface under the store's identities but did not record the face's tolerance on it, as every other place that gives a face its surface does (Brep::sync_face_surface_tolerance). A query on the store's B-rep that reaches a face through its surface (SmSurface::GetFace()->GetTolerance) then stopped at the unported SmFace::GetTolerance (topology.face_p2). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #681, where it was found (agreed with @brett19 there).
What.
SweepStore::insert_bodyowns each face surface under the store's identities but did not record the face's tolerance on the surface, as every other place that gives a face its surface does (Brep::sync_face_surface_tolerance). It now calls it for each face whose surface it owns.Why. A query on a store B-rep that reaches a face through its surface (upstream
SmSurface::GetFace()->GetTolerance()) found no tolerance there and stopped at the unportedSmFace::GetTolerance(topology.face_p2). On main this is masked wherever a query works on an owner-less copy of the B-rep; #681's owner-keeping copies exposed it (sweep::topology_sweep::store::tests::axis_classification_reaches_the_native_face_boundary).Test.
sweep::topology_sweep::store::tests::inserted_breps_record_face_tolerances_on_their_surfaces: a face with a plane and tolerance 2.5e-4 inserted into a store; its surface must report the face's zone tolerance. On main it fails withUnported SmFace::GetTolerance.Checks (VM, base 9013227): fmt; clippy with and without
difftest/cpp;cargo test -p solidcore; wasm;cargo test -p difftest --features cpp; full difftest sweep vs the base: no case changes (206 PASS / 54 PARTIAL units on both sides, 0 failed).🤖 Generated with Claude Code