Skip to content

fix: rotational sweep's axis check keeps its B-rep edits (#681 site 4) - #881

Closed
erlis wants to merge 1 commit into
tangency-labs:mainfrom
erlis:fix/sweep-store-gap-snapshot
Closed

erlis wants to merge 1 commit into
tangency-labs:mainfrom
erlis:fix/sweep-store-gap-snapshot

Conversation

@erlis

@erlis erlis commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Claim for site 4 of #681 (sweep/topology_sweep/store/classification.rs): SmPrimitiveCreation::CreateRotationalSweep's axis check runs SmFace::CurveOnClassify on a private copy of the B-rep. The UV trims and tolerance growth that the interval point classification makes are dropped there; upstream keeps them on the B-rep. Plan: run it on a shared CurveOnClassifyCache and copy back with apply_uv_trim_updates, as the fillet session's classification does.

Work in progress; the description will carry the difftest numbers.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@erlis

erlis commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Closing: measured first, and this site has no observable effect in difftest today.

  • Geometry::vertex_face_gap's per-query copy is never reached here: axis_inside_face classifies with has_big_gaps = false, and the adapter's gap is only read when it is true.
  • What the private copy could drop is the interval point classification's UV trims, tolerance growth and gap caches. With the fix applied (classification on a CurveOnClassifyCache, copied back with apply_uv_trim_updates, as the fillet session does) plus a probe, the five units that reach CreateRotationalSweep gave 23 axis checks, all in sweep.api_brep, and none of them changed the B-rep: no UV trims, no tolerances, no gap caches. All five units pass with and without it.

With no case to prove it on main, I'm not proposing the change. The patch is kept locally in case a fixture ever reaches this path with edits.

🤖 Generated with Claude Code

@erlis erlis closed this Oct 25, 2026
@erlis
erlis deleted the fix/sweep-store-gap-snapshot branch October 25, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant