Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing: measured first, and this site has no observable effect in difftest today.
With no case to prove it on main, I'm not proposing the change. The patch is kept locally in case a fixture ever reaches this path with edits. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claim for site 4 of #681 (
sweep/topology_sweep/store/classification.rs):SmPrimitiveCreation::CreateRotationalSweep's axis check runsSmFace::CurveOnClassifyon a private copy of the B-rep. The UV trims and tolerance growth that the interval point classification makes are dropped there; upstream keeps them on the B-rep. Plan: run it on a sharedCurveOnClassifyCacheand copy back withapply_uv_trim_updates, as the fillet session's classification does.Work in progress; the description will carry the difftest numbers.
🤖 Generated with Claude Code