fix(eval): preserve campaign accounting and evaluator revisions - #595
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensemble judges now receive the complete campaign scoring input, including cost-ledger context, phase, and tags.
Forwarding
judgeVersioninto Eval invalidates cached campaign scores when evaluator configuration changes.The trust gate consumes Eval's maintained score contract directly.
The library and both generated application templates adopt the same published execution and evaluation dependencies.
The Interface override is removed.
README, API references, and shipped optimization skills distinguish rater agreement, evaluator accuracy, exploratory evidence, and release evidence.
The scheduler overlap regression declares its intended concurrency explicitly instead of assuming the host has three CPUs.
Validation:
6998b8a09862a3fa757e6bc5fc5e4f11080575a8with the unchanged checked-in gate.Run and complete proof artifact.
1370982601and8392146.Frozen install, typecheck, 391 incident-gate tests, build, generated projects, and Knip also passed.
The PR verification artifact retains their complete logs: 4 default-template tests and 15 chat-template tests.
Forcing the production scheduler to one concurrent task also failed the overlap regression; restored source passed.
The signoff used a dedicated Linux x64 runner with Node 24.18.0, pnpm 11.24.0, four CPUs, and 15 GiB RAM.
KNIP_DISABLE_RAW_TRANSFER=1disables Knip's optional large-buffer transfer optimization without disabling checks.The gate configuration hash matches the reviewed source:
24dd467f0b03ece6aaeafed27c560b0763db9221fae3b1e62adbf030123a0623.An earlier run on the contended local VM passed 6,225 tests and hit one five-second UI-module import timeout.
That unchanged test file subsequently passed all 14 tests locally; the import took 1.3 seconds.
The dedicated runner then passed both complete randomized suites.
The temporary verification workflow stays outside this PR and will not land on main.