fix(dx): verify quickstarts and correct evaluation guidance - #750
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented first run could fail before generated declarations existed, several guides overstated statistical and execution guarantees, and the existing-agent example could make paid calls while displaying zero cost. The README now has a verified package-consumer quickstart, guides describe the actual controls and limitations, and the existing-agent example focuses on an offline adapter with separate metered-call guidance.
The optimizer examples share one parser for endpoint token rates. The single-optimizer worker now passes those rates to its transport, charge reservation, and receipts. The package check compares the quickstart output with the README while retaining assertions on complete score distributions.
This also fixes a reporting defect found during the audit: failure-cluster percentages used the five displayed exemplars as their numerator. They now count every affected failed run once per cluster, with regression coverage for seven failures, duplicate findings, and overlapping clusters.
Validation:
No paid provider calls were made. The 29 external links were inventoried but not refreshed. Fixture results do not establish optimizer effectiveness or population-level release evidence.