feat: reusable Router search, verified phone, and Twilio webhook primitives - #304
Merged
Merged
Conversation
drewstone
marked this pull request as ready for review
September 15, 2026 22:14
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusable primitives in the existing integrations library
Extract generally useful provider protocol behavior from SUPER without introducing another agent loop, evaluator, permission engine, signup database or provider registry.
/tangle-search:TangleSearchClientand pure request/response functions for consumers with an existing transport. One Router endpoint, explicit host-selected credentials, optional provider pinning, query/provider correlation and preservation of unknown costs. No direct You.com client, automatic paid fallback or retry./twilio: managed verification, native SMS form encoding with delivery callbacks, original-body preservation, account/phone/receipt correlation, phone normalization and exact native form-signature authentication. A messaging-only consumer needs no Verify service. Sends have no automatic retry or claimed native idempotency.createTwilioWebhookProviderextends the existing/webhooksrouter. Event identity includes status so an accepted event does not deduplicate a later delivery event. It does not create another webhook engine.Enrollment, Terms/Privacy consent, sessions, workspace ownership, reply shortening, sender registration and billing policy stay in consuming products. These are host APIs, not model-callable session-creation tools. Existing Hub tool adapters are unchanged; this does not claim the current Twilio Hub connector now exposes Verify.
Packaging and documentation
Two additive subpath exports, matching tsup entries, no new dependency or manual version bump.
CHANGELOG.mdrecords Unreleased changes;docs/host-search-and-phone.mddocuments usage, correlation, transport limits, webhook/replay boundaries and rollout. Existing release automation owns the published version.Companion non-draft PRs:
SUPER imports exact generated modules pinned to this source until a compatible release is published. It removes its independent protocol bodies; no silent local fallback remains.
Full-checkout verification
Passed on
ad0e48ccf8fd191be5e1628949249047547bc634:pnpm run releasepacked-artifact verification, without--publish. The package and 627 bundled manifests verified successfully.Evidence: https://github.com/tangle-network/agent-integrations/actions/runs/35030132223 (artifact
shared-primitives-304contains exact source, commit, typecheck/test/release logs).This supersedes the earlier isolated authoring-test limitation. The existing 28 focused provider/webhook checks are part of the tested repository; no provider credentials or live paid calls are used by these tests.
Non-draft and ready for review. No main merge, tag, npm publication, live search, OTP, SMS, account changes or deployment was performed. Passing protocol tests is not evidence of a delivered customer conversation or completed logistics task.