Skip to content

fix(knowledge): bind promotions to verified source snapshots - #208

Merged
drewstone merged 1 commit into
mainfrom
fix/promotion-source-snapshot
Sep 14, 2026
Merged

drewstone merged 1 commit into
mainfrom
fix/promotion-source-snapshot

Conversation

@drewstone

@drewstone drewstone commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Concurrent run-local edits could make promotion copy content that its citation check never inspected, then record the digest of an older page.
Promotion now captures each selected page and its cited support, verifies their canonical page identities against the inspected snapshot, and transfers those captured strings.
A changed identity raises path-conflict before shared pages are written.
Edits after capture cannot replace the promoted version.

The package advances to 16.0.1 without changing public contracts.

Validation:

  • The new claim/support race regressions failed before the fix and pass afterward.
  • All 7 promotion tests pass, including a source edit after capture, matching receipt digests, and an untouched unselected page.
  • Ubuntu CI passed 876 tests with 7 skips, lint, typecheck, build, package lifecycle/API verification, and compatibility with Eval 0.174.
  • The official optimizer job passed its GEPA and SkillOpt integration tests.
  • The version gate and diff checks pass locally.
  • A Linux Node 22 recheck passed all 151 tests across the affected local failure suites and promotion.
    It used an init process, temporary in-memory test storage, and one worker without changing test timeouts.

The Darwin full suite encountered the existing Linux-only exact-candidate boundary.
The initial Docker run encountered one unreaped zombie and eight timeouts.
The corrected container recheck and ordinary Ubuntu CI passed without further source changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-12T23:07:22.267095Z dd7266b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@drewstone
drewstone merged commit fc0a4cc into main Sep 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant