fix(knowledge): bind promotions to verified source snapshots - #208
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent run-local edits could make promotion copy content that its citation check never inspected, then record the digest of an older page.
Promotion now captures each selected page and its cited support, verifies their canonical page identities against the inspected snapshot, and transfers those captured strings.
A changed identity raises
path-conflictbefore shared pages are written.Edits after capture cannot replace the promoted version.
The package advances to 16.0.1 without changing public contracts.
Validation:
It used an init process, temporary in-memory test storage, and one worker without changing test timeouts.
The Darwin full suite encountered the existing Linux-only exact-candidate boundary.
The initial Docker run encountered one unreaped zombie and eight timeouts.
The corrected container recheck and ordinary Ubuntu CI passed without further source changes.