fix(knowledge): remove implicit ancestry ceiling and preserve long histories - #209
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A finite history longer than 64 ancestors was classified as invalid durable state. After enough continuations, ordinary Knowledge retrieval therefore stopped seeing valid retained work.
Remove the source-level ancestry ceiling. A caller that needs a bounded read can provide
maxAncestors(including zero); exact-bound chains work and over-bound chains fail explicitly, never silently truncate. Cycle detection, parent/identity validation, conflict detection and filesystem containment remain unchanged.No new store, cache, scheduler, maintenance agent, ontology, or research policy. Five changed files, one clean commit. Version 17.0.0 and generated API surface follow this repository's existing exported-shape version policy; no package has been published.
Proof
pnpm test, build, API surface generation,verify:package, andgit diff --checkpassed.Limits
This fixes the arbitrary correctness cutoff; it does not make full-chain corpus loading or receipt hashing constant-time. It does not claim remote durability, high-throughput search, or cross-host consistency. The complete finite-chain default trusts the caller-supplied lineage authority; callers exposing adversarial/dynamically unbounded authorities should supply a read bound.