fix(supervise): classify agent-provider-tangle's typed JSON bound refusal - #1268
Merged
Merged
Conversation
…usal Provider 1.5.0 throws JsonBoundError (code JSON_BOUND_VIOLATION) where it threw a plain Error; the classifier files it with the schema violations — a rejected request at admission, a provider contract violation after — closing #1204's exhibit 6. Exhibit 3 is delivered rather than thrown since provider 1.4.0; the doc says so instead of calling it uncovered. 0.235.1. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
|
Cutting v0.235.1 at the merge commit now (tip of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1266 (#1204). Pairs with tangle-network/agent-sdk#338.
0.235.0 could only leave #1204's exhibit 6 (
value exceeds its JSON bound) on'unobservable'because the provider threw it as a plainErrorwith no code. agent-sdk#338 makes it aJsonBoundErrorwithcode: 'JSON_BOUND_VIOLATION'; this recognises the code and files it with the schema violations —'request-rejected'at admission,'provider-contract'after — and pins both phases in the unit test, alongside the pre-1.5.0 plain-Errorshape that still lands on the safe side.Exhibit 3 (an event without a stable id) is delivered rather than thrown since provider 1.4.0 (agent-sdk#334) and no longer reaches this path; the classifier's doc says so instead of calling it uncovered.
Patch: 0.235.1 (no exported shape changes).
typecheck,biome,docs:api,docs:freshness, fixtures all exit 0; retained-pending-cause + retained-environment-release 26 / 26. Merge-clean againstmain. Merge order: agent-sdk#338 first is not required — this only reads acodestring — but the Lab bump to provider 1.5.0 is what makes exhibit 6 classify in practice.🤖 Generated with Claude Code