fix(supervise): settle a root that never spawned as no-children-spawned - #1269
Merged
Merged
Conversation
A root that ran to completion under budget, selected nothing, and never spawned a child settled `all-children-down` with `downCount: 0`. That reads as a fleet failure. Fifteen sandbox-placed directors settled that way in one week while the actual fault was that the root did its work in bash and never recursed, and every reader went looking at the fleet. The residual bucket now checks fleetYield.spawned and names the case. `all-children-down` asserts what its name says: at least one child was spawned and none delivered. The two tests that pinned the old value on a zero-spawn tree flip; one of them was about token telemetry and never cared which reason it got. Release 0.236.0: the no-winner reason union widens.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A root that ran to completion under budget, selected nothing, and never spawned a child settled
no-winner/all-children-downwithdownCount: 0. That reads as a fleet failure. Fifteen sandbox-placed directors settled that way this week (#1245) while the actual fault was that the root did its research in bash and never recursed — and every reader, including me, went looking at the fleet first. Today'ssandbox-mcp-probe-20260916d, which calledstopdeliberately after spawning nothing, got the same label.types.tsalready acknowledged the ambiguity whendriver-failedwas carved out; this carves out the other half.Change
no-children-spawnedon theno-winnerlifecycle arm, chosen in the residual bucket whenfleetYield.spawned === 0.all-children-downnow asserts what its name says: at least one child was spawned and none delivered.Release
0.236.0 — the exported reason union widens. A consumer that switched on the reason and treated the old value as "the fleet lost everything" adds the new arm; a consumer that only counted
no-winneris unaffected.Proof, local
tsc --noEmitclean; biome clean;vitest runonsupervisor.test.ts,tests/kernel/supervise.test.ts,tests/mcp/delegate.test.ts,tests/kernel/supervise-full-profile-bridge.test.ts,tests/kernel/retained-environment-release.test.ts: 204/204. Build, api:surface, docs freshness pass. Full suite running.🤖 Generated with Claude Code