Bump DspTap to df482d1 (wave 1 of the FFT plan) - #52
Merged
Merged
Conversation
Moves submodules/dsptap from 5ca3b1c to df482d1, the DspTap main head after the ten wave-1 PRs (#17-#25): the 32-bit sample-clock fix in psola/pvoc, the embedded QEMU legs, the bench and ratchet scaffold, the Stage 2a FFT test suite, the sample-format substrate with a double profile and the fft_arith trait, the packed-spectrum view, the provenance statement, the capi FFT exposure and the plan itself. MuTap consumes fft.h and nn.h from the submodule; neither changed numerically. Gate: tests/fingerprint_harness.cpp built at the old and the new pin on the same host (Linux x86-64, GCC 13.3, Release) prints identical FINGERPRINT lines for all seven components in both profiles. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ZPTzNxo5Fe4EtpXXKf7Sy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Moves
submodules/dsptapfrom5ca3b1ctodf482d1, the DspTapmainhead after the ten wave-1 PRs of the FFT plan (tap/DspTap #17, #18, #19, #20, #21, #22, #23, #24, #25). Nothing else changes in MuTap.Why
The rollout rule in DspTap's plan (docs/audit-fft-and-code-smells.md, Part 3): every DspTap stage is followed by a MuTap pin bump, gated by the fingerprint harness that #50 added. Wave 1 changed nothing MuTap consumes numerically (
fft.his untouched;nn.his untouched), so this bump must be a fingerprint no-op, and it is.Verification
tests/fingerprint_harness.cppbuilt and run on one host (Linux x86-64, GCC 13.3, Release) at the old pin and at the new pin: all fourteenFINGERPRINTlines identical (fdaf, fd_kalman, pem_afc, postfilter, nn_suppressor, aec_chain, aec_chain_nn; float and double).df482d1is green on its own CI (hosted linux/windows/macos, and the four QEMU legs cortex-m4-softfp / m4f / m33 / m55) for every merged PR; the last four squash commits'mainruns were still in the queue when this PR was opened, so this PR's own CI is the confirmation for MuTap.mainrun.Notes for the reviewer
submodules/dsptap5ca3b1c → df482d1, the identical tree on DspTapmain(squash merges, so the wave-1 branches will be deleted). MuTap-Max pins MuTap and picks this up at its next re-pin.🤖 Generated with Claude Code
https://claude.ai/code/session_019ZPTzNxo5Fe4EtpXXKf7Sy
Generated by Claude Code