Skip to content

Sync TapHouse v7: tidy.sh false-clean fix #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tap merged 1 commit into from
Oct 9, 2026
Merged

Sync TapHouse v7: tidy.sh false-clean fix #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ on: [push, pull_request]

jobs:
drift:
uses: tap/taphouse/.github/workflows/drift-check.yml@v6
uses: tap/taphouse/.github/workflows/drift-check.yml@v7
with:
ref: v6
ref: v7
icon: MuTap

clang-tidy:
Expand Down
8 changes: 7 additions & 1 deletion scripts/tidy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,13 @@ echo "== clang-tidy ($tidy) over ${#files[@]} file(s) =="
fail=0
for f in "${files[@]}"; do
out="$("$tidy" -p "$build" "$f" 2>/dev/null || true)"
if printf '%s\n' "$out" | grep -qE "warning:|error:"; then
# Test the captured output in-process, never through a pipe. Under pipefail,
# `printf '%s\n' "$out" | grep -q …` fails whenever grep quits at its first
# match while printf still has more than a pipe buffer to write (SIGPIPE) —
# and the `if` then took the CLEAN branch over real warnings. TapHouse's
# scripts/test-tidy.sh feeds this script multi-megabyte output to prove the
# verdict holds.
if [[ "$out" =~ (warning:|error:) ]]; then
printf '%s\n' "$out"
fail=1
fi
Expand Down
Loading