Bump DspTap to 0eb09fa (+ SampleRateTap test pin); re-record icount; correct the construction-share claim - #17
Merged
Conversation
DspTap #38 shares the Kaiser window's Bessel series across the prototype design (bit-identical coefficients). RatioTap designs at construction for every profile, so every workload's construction got cheaper: per profile and direction, identical across float/Q15/Q31 -- M33 -37..-299 M, Hexagon -4.7..-35 M, M55 -0.6..-4.6 M. Ten M33 and eight Hexagon scenarios left the two-sided gate (M33 down_q15_eco -28.9%); baselines re-recorded on all three targets. The test-only sampleratetap pin moves in step (no header changes in 5315689..2b4dff1) so both repos keep the identical dsptap tree the dev-only include path relies on. PLAN.md: M7e ledger entry, and a correction. M7c deferred coefficient baking because "construction is <0.3% of every workload"; a construct-only measurement of every scenario shows 3-5% on M55, 5-37% on Hexagon and up to 63% of the M33 Q15 workloads (74% before this change), which dilutes the M33 gate for hot-path regressions ~2-3x. Host: 78/78 under GCC and clang with TAP_RATIO_WERROR; scripts/tidy.sh clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G3HxzEGiZp7jStoMuYNuBK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
submodules/dsptapmoves28a34a1→0eb09fa, which includes kaiser: share the Kaiser window's Bessel series (bit-identical, −32% on M33) DspTap#38. The test-onlysubmodules/sampleratetapmoves5315689→2b4dff1in step.bench/baselines.jsonis re-recorded on M33, M55 and Hexagon.Why
DspTap#38 computes the Kaiser window's Bessel series once, for half the taps, and mirrors it. The coefficients are bit-identical and the design is cheaper. RatioTap designs its prototype at construction for every profile (
phase_table.h→design_prototype), so every ratchet workload's construction got cheaper:down_q15_eco, −28.9 %.The SampleRateTap pin moves too because of an invariant. RatioTap compiles SampleRateTap's headers against its own
tap::dsp, and that relies on both repos pinning the identical DspTap tree (see the comment inCMakeLists.txt). SampleRateTapmainnow pins0eb09fa. There are no header changes in5315689..2b4dff1.Verification
Construction only. The deltas are constant per profile and direction, and identical across float/Q15/Q31:
down economyis −70.7 M on M33 in all three formats. The coefficients are bit-identical (DspTap#38's fingerprints on M33 and x86 GCC/clang). The scipy reference vectors and the cross-validation floors pass unmoved.Host. 78/78 tests pass under GCC 13 and clang 18 with
TAP_RATIO_WERROR=ON;scripts/tidy.shis clean.Ratchet. It flagged the moves above before the update. After
icount.py --updateit passes on all three targets, built with CI's configure line, the repo's plugin (same pinned header SHA), arm-none-eabi-gcc 13.2.1, hexagon-clang 19.1.5 and plugin-enabled qemu-hexagon 8.2.2. This PR's ratchet job is the CI cross-check.Construction share. A scratch program builds only each scenario's converter (no audio) and is counted on every target:
Not run locally. The bare-metal and Hexagon test legs, left to CI.
Notes for the reviewer
28a34a1→0eb09fa(brings DspTap's FFT stages andmath.h, unused here); SampleRateTap5315689→2b4dff1(test-only).🤖 Generated with Claude Code
https://claude.ai/code/session_01G3HxzEGiZp7jStoMuYNuBK
Generated by Claude Code