Re-pin the SampleRateTap test dependency to its post-step-P main (P.4) - #19
Merged
Merged
Conversation
Moves submodules/sampleratetap 2b4dff1 -> 5e2057f, SampleRateTap's main after its step-P PR (#48). That range changes no header under include/ and keeps the same DspTap pin (0eb09fa), so the tree the cross-validation compiles against is unchanged: 82/82 tests pass and the four cross-validation lines are byte-identical to before. The monorepo migration's step 0 snapshots against this pin, so the cross-validation lines it records come from the same async tree the import compiles (step P.4 of the plan). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VR1VC4SDGxHZQQsQvPBaA
tap
marked this pull request as ready for review
September 27, 2026 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This moves
submodules/sampleratetapfrom2b4dff1to5e2057f, which is SampleRateTap'smainafter tap/SampleRateTap#48 merged. It is step P.4 of the monorepo migration plan.Why
Step 0 of the migration snapshots the cross-validation lines against this pin. The pin must be the same async tree that the import later compiles.
Verification
git diff 2b4dff1 5e2057f -- include/in SampleRateTap is empty.0eb09fa, the same as RatioTap's.-DTAP_RATIO_WERROR=ONpasses 82/82 tests. The submodules were checked out at the new pin recursively.[ measured ] cross-validationlines are byte-identical to the previous pin's: −98.5 / −98.0 / −90.4 / −89.8 dB, with limits 3e-5 and 8e-5.Notes for the reviewer
sampleratetap2b4dff1 → 5e2057f. It is a test-only dependency.5e2057fis on SampleRateTap'smain, so it stays reachable.🤖 Generated with Claude Code
https://claude.ai/code/session_015VR1VC4SDGxHZQQsQvPBaA