Repository navigation
Conversation
This reverts commit a03323a.
Member
|
Please, include a short explanation why you are doing this (Tarantool CI is broken because blah-blah-blah...) |
Member
|
Duplicate of #553. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #549.
The change was merged before the
config.checksoption itself. It was intended to isolate metrics tests from alerts produced by system checks.The option implementation is now being reworked, so this workaround is no longer needed. Meanwhile, it breaks Tarantool CI when metrics tests run against a Tarantool build that does not recognize
config.checks.