Skip to content

ci: run CI on external pull requests - #555

Merged
patapenka-alexey merged 1 commit into
tarantool:masterfrom
Totktonada:run-ci-on-external-pull-requests
Aug 27, 2026
Merged

patapenka-alexey merged 1 commit into
tarantool:masterfrom
Totktonada:run-ci-on-external-pull-requests

Conversation

@Totktonada

Copy link
Copy Markdown
Contributor

Currently, CI is run only on pushing a branch. The jobs are shown in the pull request UI, when its source branch in the base repository. However, if I send a pull request from a fork, there are no CI checks.

Let's fix it similarly to how tarantool/crud does: run on branch push and pull request both, but skip the pull request run in jobs if the pull request is sent from the base repository. This way the jobs are not duplicated.

Also, while I'm here, add recent tarantool versions to the CI matrix.

Currently, CI is run only on pushing a branch. The jobs are shown in the
pull request UI, when its source branch in the base repository.
However, if I send a pull request from a fork, there are no CI checks.

Let's fix it similarly to how tarantool/crud does: run on branch push
and pull request both, but skip the pull request run in jobs if the pull
request is sent from the base repository. This way the jobs are not
duplicated.

Also, while I'm here, add recent tarantool versions to the CI matrix.
@Totktonada

Totktonada commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor Author

I guess that it is expected that it is not in effect in this pull request, because the workflow file has to be in the target branch. It runs, but after some delay (possibly after a manual approve, but that doesn't shown to me).

@patapenka-alexey patapenka-alexey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@patapenka-alexey
patapenka-alexey merged commit 578a43c into tarantool:master Aug 27, 2026
19 checks passed
@Totktonada
Totktonada deleted the run-ci-on-external-pull-requests branch August 27, 2026 10:01
@patapenka-alexey patapenka-alexey mentioned this pull request Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants