core: protect ro nodes on disconnect#252
Open
Col-Waltz wants to merge 1 commit into
Open
Conversation
oleg-jukovec
requested changes
Jun 3, 2026
oleg-jukovec
left a comment
oleg-jukovec
left a comment
Contributor
There was a problem hiding this comment.
Please, add a changelog entry + link to the PR: #248
Col-Waltz
force-pushed
the
Col-Waltz/protect-disconnect-on-ro
branch
from
89e9d3e to
7195d22
Compare
oleg-jukovec
requested changes
Jun 18, 2026
oleg-jukovec
left a comment
oleg-jukovec
left a comment
Contributor
There was a problem hiding this comment.
Please, describe the change for a user in the CHANGELOG.md.
Col-Waltz
force-pushed
the
Col-Waltz/protect-disconnect-on-ro
branch
from
7195d22 to
da46d48
Compare
oleg-jukovec
requested changes
Jun 18, 2026
Adds protection for on_disconnect trigger. After leader change it may return ERR_READONLY while deleting consumers. Now this trigger performs only local operations on ro node.
Col-Waltz
force-pushed
the
Col-Waltz/protect-disconnect-on-ro
branch
from
da46d48 to
3b53938
Compare
oleg-jukovec
approved these changes
Jun 19, 2026
palage4a
requested changes
Jun 22, 2026
| return make_self(driver, space, name, tube_type, id, opts) | ||
| end | ||
|
|
||
| -- function cleans local temporary spaces on startup to avoid |
There was a problem hiding this comment.
A sentence should be started with capital letter.
https://www.tarantool.io/en/doc/latest/contributing/lua_style_guide/#commenting
Suggested change
| -- function cleans local temporary spaces on startup to avoid | |
| -- Cleans local temporary spaces on startup to avoid |
| -- The "RUNNING" and "WAITING" states do not require additional actions. | ||
| local function on_state_change(state) | ||
| if state == queue_state.states.STARTUP then | ||
| cleanup_temp_spaces() |
There was a problem hiding this comment.
Could you please provide the test that checks cleanup after RW->RO->RW transition?
It seems to me, this case does not covered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds protection for on_disconnect trigger. After leader change it may return ERR_READONLY while deleting consumers. Now this trigger performs only local operations on ro node.